fix(core): use the current CLI to prepare external Yarn classic projects #4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Jul 27, 2022
rally25rs
previously approved these changes
Jul 27, 2022
There was a problem hiding this comment.
This did seem to resolve an issue of differing github dependency checksums I was seeing between 2 machines. The package.json of the cloned dependency repo was being modified differently depending on which yarn was being called to run these commands to prepare the dependency.
With this PR they started generating the same checksum.
arcanis
reviewed
Jul 27, 2022
1 task
rally25rs
approved these changes
Aug 1, 2022
merceyz
added a commit
that referenced
this pull request
Aug 19, 2022
…cts (#4682) * fix(core): use the current CLI to prepare external Yarn classic projects * fix(core): revert changes made to the Manifest by `set version` * fix: add `--yarn-path`
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
yarn set version classicis run it updates theManifestto contain apackageManagerfield with the latest Yarn version which causes the results to change depending on when it runs.How did you fix it?
yarn set version.Checklist