Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn audit exit code overflow #6748

Closed
MRoci opened this issue Nov 30, 2018 · 0 comments
Closed

yarn audit exit code overflow #6748

MRoci opened this issue Nov 30, 2018 · 0 comments
Assignees
@imsnif
Labels
cat-bug

Comments

@MRoci
Copy link

MRoci commented Nov 30, 2018

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
yarn audit set the exit code related to the number of issues found.
If the number of issues is greater than 255 the exit code overflows
This means that if are found exactly 256 issues the exit code is 0.

If the current behavior is a bug, please provide the steps to reproduce.
This is a package.json crafted to trigger exactly 256 issues

https://gist.github.com/MRoci/e28694334ff6771cc7fd14e6d762f355

What is the expected behavior?
The expected behaviour should be an exit status always different from 0 in case of failure

Please mention your node.js, yarn and operating system version.
yarn version v1.12.3
node version: any that i know
OS: OSX Mojave 10.14.x
@ghost ghost assigned imsnif Nov 30, 2018
@ghost ghost added the triaged label Nov 30, 2018
@rally25rs rally25rs added cat-bug and removed triaged labels Dec 4, 2018
@antrew antrew mentioned this issue Dec 14, 2018
Merged
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jan 17, 2019
@kleink
yarn: Update to 1.13.0.
82e388f 
## 1.13.0

- Implements a new `package.json` field: `peerDependenciesMeta`

  [6671](yarnpkg/yarn#6671) - [**Maël Nison**](https://twitter.com/arcanis)

- Adds an `optional` settings to `peerDependenciesMeta` to silence missing peer dependency warnings

  [6671](yarnpkg/yarn#6671) - [**Maël Nison**](https://twitter.com/arcanis)

- Implements `yarn policies set-version [range]`. Check [the documentation]() for usage & tips.

  [6673](yarnpkg/yarn#6673) - [**Maël Nison**](https://twitter.com/arcanis)

- Fixes a resolution issue when a package had an invalid `main` entry

  [6682](yarnpkg/yarn#6682) - [**Maël Nison**](https://twitter.com/arcanis)

- Decreases the size of the generated `$PATH` environment variable for a better Windows support

  [6683](yarnpkg/yarn#6683) - [**Rowan Lonsdale**](https://github.com/hWorblehat)

- Fixes postinstall scripts for third-party packages when they were referencing a binary from their own dependencies

  [6712](yarnpkg/yarn#6712) - [**Maël Nison**](https://twitter.com/arcanis)

- Fixes yarn audit exit code overflow

  [6748](yarnpkg/yarn#6748) - [**Andrey Vetlugin**](https://github.com/antrew)

- Stops automatically unplugging packages with postinstall script when running under `--ignore-scripts`

  [6820](yarnpkg/yarn#6820) - [**Maël Nison**](https://twitter.com/arcanis)

- Adds transparent support for the [`resolve`](https://github.com/browserify/resolve) package when using Plug'n'Play

  [6816](yarnpkg/yarn#6816) - [**Maël Nison**](https://twitter.com/arcanis)

- Properly reports the error codes when the npm registry throws 500's

  [6817](yarnpkg/yarn#6817) - [**Maël Nison**](https://twitter.com/arcanis)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imsnif imsnif

Labels
cat-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rally25rs @imsnif @MRoci