Add %LocalAppData%\Yarn\.bin to PATH as part of installation #1129
Conversation
| Permanent="no" | ||
| Part="last" | ||
| Action="set" | ||
| System="yes" |
There was a problem hiding this comment.
This is a per-user path, so other users in the same system don't have access to it.
This needs to be set up for each user that runs yarn. This will work on single-user systems, though.
An advantage of making it not System is that it will(?) roam with the user profile. While the local appdata folder won't roam, local installs with yarn will go to the local appdata, so they'll show up in the path once you create the folder with yarn.
There was a problem hiding this comment.
Can you, maybe, set the path to be literally %LocalAppData%/Yarn/.bin, and hope the shell expands it when evaluating the PATH?
This, of course, will definitely not work on windows xp.
There was a problem hiding this comment.
Good catch, thanks @Kovensky! I updated it to add it to the user environment variable rather than the system one. That should work fine. I don't think the shell expands environment variables like %LocalAppData% when resolving the PATH.
* Change PATH from `%LocalAppData%\Yarn\.bin` to `%LocalAppData%\Yarn\config\global\node_modules\.bin` in the Windows installer * Fixes the Windows PATH introduced in c091ac4 & yarnpkg#1129 * Allows global packages to be accessible through Windows PowerShell and CMD
Summary
Updates the Windows installer to add
%LocalAppData\Yarn\.binto thePATH, so that we can remove the "path setup" section that was added in the docs (https://yarnpkg.com/en/docs/install)Test plan
Ran installer on my computer, ensured the PATH was updated correctly:
Uninstalled Yarn, ensured both PATH additions were removed.