compare current version against latest and not wanted version in outdated command #4519

danez · 2017-09-22T11:47:57Z

Summary
current and wanted version might be the same but latest is a new major version
and as current and wanted are compared against each other it results in most outdated entries being white instead of the proper color

Here a before/after screenshot:

buildsize · 2017-09-22T11:59:28Z

This change will increase the build size from 9.92 MB to 9.93 MB, an increase of 378 bytes (0%)

File name	Previous Size	New Size	Change
yarn-[version].noarch.rpm	858.23 KB	858.21 KB	-21 bytes (0%)
yarn-[version].js	3.78 MB	3.78 MB	228 bytes (0%)
yarn-legacy-[version].js	3.83 MB	3.83 MB	228 bytes (0%)
yarn-v[version].tar.gz	863.97 KB	863.99 KB	21 bytes (0%)
yarn_[version]all.deb	653.25 KB	653.18 KB	-78 bytes (0%)

BYK · 2017-09-24T18:12:32Z

I don't have a strong opinion on this but I'd like to verify this behavior with @yarnpkg/core. Anyone willing to approve this patch?

@danez it would be great if you could add some tests for this btw.

Haroenv · 2017-09-25T07:34:37Z

What about adding a colour key on the bottom here, it might be hard to tell those apart otherwise

kaylie-alexa · 2017-09-25T14:54:53Z

Thanks @danez! The code change looks fine, but I agree with @Haroenv that it's not as intuitive that the color changes between major vs minor versions.

danez · 2017-09-25T15:23:01Z

Thanks for your feedbacks. I also noticed that in the above case it is also weird because all the changes in the screenshot are considered "major/breaking" (0.1.0 -> 0.2.0 or 1.0.0 > 2.0.0), though they still have different colors.

I guess the difference in the color should be:

red
- You need to run yarn upgrade pkg-name --latest to update the package
- Potentially breaking (according to semver)
yellow
- If ranges are used in pkg.json, the package will be updated when running yarn run upgrade
- Potentially not breaking (according to semver)

Does that make sense?

We could also add a --latest flag here to be inline with yarn upgrade, so by default only show in-range updates unless the flag is specified? Then the flag would decide if yarn compares against wanted or latest.

For the tests I could mock the formatter and check which color is used for which dep. Does that sound okay?

danez · 2017-09-25T15:41:08Z

I also just noticed that upgrade-interactive uses the same coloring scheme that outdated uses which seems confusing to me. For example flow-bin is not in my range, similar to all other dependencies, but is yellow (see screenshot). So the most understandable difference between the colors for me is about is the upgrade in my current range (yellow) or not (red).

kaylie-alexa · 2017-09-26T06:10:42Z

I also noticed that in the above case it is also weird because all the changes in the screenshot are considered "major/breaking" (0.1.0 -> 0.2.0 or 1.0.0 > 2.0.0), though they still have different colors.

(0.1.0 -> 0.2.0) is not considered major/breaking, since it's a minor bump and should be backwards compatible

I guess the difference in the color should be:

red
You need to run yarn upgrade pkg-name --latest to update the package
Potentially breaking (according to semver)
yellow
If ranges are used in pkg.json, the package will be updated when running yarn run upgrade
Potentially not breaking (according to semver)

I think it's confusing to have a color mean two things (how to upgrade and potentially breaking / non-breaking--the latter especially feels inconclusive). Ideally it should use the same key as upgrade-interactive

 "<red>"    : Major Update backward-incompatible updates
 "<yellow>" : Minor Update backward-compatible features
 "<green>"  : Patch Update backward-compatible bug fixes

For the tests I could mock the formatter and check which color is used for which dep. Does that sound okay?

Sounds good to me!

I also just noticed that upgrade-interactive uses the same coloring scheme that outdated uses which seems confusing to me.

I'm not sure I follow. The colors seem to correctly reflect the key in upgrade-interactive (major bumps being in red for backwards-incompatible change). The difference is that flow-bin is a minor bump, whereas the rest are major bumps.

danez · 2017-09-27T09:30:45Z

@kaylieEB thanks for the clarification, seems I mixed some things up. I always thought that when the major version is 0 that semver defines that the minor version gets promoted to major, but that is not the case. The specification only says:

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

It seems I confused the semver spec with the way how the caret operator works, but that is not part of the specification.

Will try to finish this today.

current and wanted might be the same but latest is the new major version which results in most outdated entries beeing white instead of the proper color

kaylie-alexa · 2017-10-05T16:40:48Z

@danez ping! need any help?

danez · 2017-10-05T18:38:15Z

I think it is done now, I also added the legend.

danez · 2017-10-05T18:39:18Z

src/reporters/lang/en.js

@@ -114,6 +114,8 @@ const messages = {
  allDependenciesUpToDate: 'All of your dependencies are up to date.',
  legendColorsForUpgradeInteractive:
    'Color legend : \n $0    : Major Update backward-incompatible updates \n $1 : Minor Update backward-compatible features \n $2  : Patch Update backward-compatible bug fixes',
+  legendColorsForOutdated:


This is the same as legendColorsForUpgradeInteractive should I merge them? If yes what to name them?

yeah I'd prefer merging them. How about legendColorsForVersionUpdates?

Okay changed :)

kaylie-alexa · 2017-10-10T16:32:38Z

Thanks so much for your help @danez ! I'll merge once CI passes :)

danez · 2017-10-10T16:47:59Z

Thank you :)

lint

…ated command (yarnpkg#4519) **Summary** `current` and `wanted` version might be the same but `latest` is a new major version and as current and wanted are compared against each other it results in most outdated entries being white instead of the proper color Here a before/after screenshot: ![bildschirmfoto 2017-09-22 um 13 41 56](https://user-images.githubusercontent.com/231804/30743120-9efa6824-9f9c-11e7-9f17-7b511597e13b.png)

danez changed the title ~~change color against latest version and not wanted in outdated command~~ compare current version against latest and not wanted version in outdated command Sep 22, 2017

arcanis assigned kaylie-alexa Sep 26, 2017

danez added 2 commits September 27, 2017 15:09

fix(outdated): Color changes against latest version and not wanted

d22f161

current and wanted might be the same but latest is the new major version which results in most outdated entries beeing white instead of the proper color

Fix flow

9956869

Add legend for colors to outdated

ceae3e4

danez commented Oct 5, 2017

View reviewed changes

Rename message id to legendColorsForVersionUpdates

ae6639a

kaylie-alexa approved these changes Oct 10, 2017

View reviewed changes

Merge branch 'master' into fix-outdated

67c317c

Update outdated.js

cd49ac1

lint

kaylie-alexa merged commit 77f5e40 into yarnpkg:master Oct 10, 2017

jasononeil mentioned this pull request Dec 1, 2017

yarn outdated --json now prints invalid JSON #5021

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compare current version against latest and not wanted version in outdated command #4519

compare current version against latest and not wanted version in outdated command #4519

danez commented Sep 22, 2017

buildsize bot commented Sep 22, 2017 •

edited

Loading

BYK commented Sep 24, 2017

Haroenv commented Sep 25, 2017

kaylie-alexa commented Sep 25, 2017

danez commented Sep 25, 2017 •

edited

Loading

danez commented Sep 25, 2017 •

edited

Loading

kaylie-alexa commented Sep 26, 2017

danez commented Sep 27, 2017 •

edited

Loading

kaylie-alexa commented Oct 5, 2017

danez commented Oct 5, 2017

danez Oct 5, 2017

kaylie-alexa Oct 8, 2017

danez Oct 9, 2017

kaylie-alexa commented Oct 10, 2017

danez commented Oct 10, 2017

compare current version against latest and not wanted version in outdated command #4519

compare current version against latest and not wanted version in outdated command #4519

Conversation

danez commented Sep 22, 2017

buildsize bot commented Sep 22, 2017 • edited Loading

BYK commented Sep 24, 2017

Haroenv commented Sep 25, 2017

kaylie-alexa commented Sep 25, 2017

danez commented Sep 25, 2017 • edited Loading

danez commented Sep 25, 2017 • edited Loading

kaylie-alexa commented Sep 26, 2017

danez commented Sep 27, 2017 • edited Loading

kaylie-alexa commented Oct 5, 2017

danez commented Oct 5, 2017

danez Oct 5, 2017

Choose a reason for hiding this comment

kaylie-alexa Oct 8, 2017

Choose a reason for hiding this comment

danez Oct 9, 2017

Choose a reason for hiding this comment

kaylie-alexa commented Oct 10, 2017

danez commented Oct 10, 2017

buildsize bot commented Sep 22, 2017 •

edited

Loading

danez commented Sep 25, 2017 •

edited

Loading

danez commented Sep 25, 2017 •

edited

Loading

danez commented Sep 27, 2017 •

edited

Loading