chore(jest): Upgrade Jest flow types #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Follow up to #5569. **Test plan** `yarn lint` should pass without errors.
arcanis
reviewed
Mar 26, 2018
| * Jest allows functions and classes to be used as test names in test() and | ||
| * describe() | ||
| */ | ||
| type JestTestName = string | Function; |
There was a problem hiding this comment.
Just copy pasted this from flow/flow-typed repo :D
|
AppVeyor is expected to fail for now. See #5574 |
arcanis
approved these changes
Mar 26, 2018
BYK
added a commit
to imsnif/yarn
that referenced
this pull request
Mar 26, 2018
**Summary** Follow up to yarnpkg#5569. **Test plan** `yarn lint` should pass without errors.
This was referenced Apr 11, 2018
arcanis
pushed a commit
that referenced
this pull request
Aug 1, 2018
…rn.lock (#5042) * test(fixtures): adjust yarn.lock and snapshots with integrity field as needed * test(integrity): adjust existing cases to integrity field authentication * test(fixtures): integrity field authentication cases * test(integrity): integration and unit tests for the lockfile integrity field * chore(deps): add ssri module * feat(checksums): add integrity field with sha512 authentication to yarn.lock * test(integrity): additional sri string options * fix(checksums): better error when algorithms are not supported * fix(checksums): proper error message for bad hash in node <= 6 * chore(integrity): fixed new flow issues * test(integrity): adjust additional test case * test(fixtures): additional integrity field authentication cases * fix(integrity): update integrity for offline-mirror cases * style(integrity): clarify conditional for flow * fix(integrity): throw sync error rather than rejecting it * Update yarn.lock with new integrity field * Upgrade ssri * Use the latest version of the SSRI package * Optimize integrity matching from lockfile a bit * Refactor digest support determination * test(error): fixed expected error wording * fix(checksum): fail validation on malformed hash or integrity * fix(test): verify integrity failure on malformed integrity string * test(fixtures): add install auth malformed integrity fixture * chore(deps): update dependency eslint-config-fb-strict to ^22.0.0 (#5570) **Summary** This Pull Request updates dependency eslint-config-fb-strict from ^20.1.0-delta.3 to ^22.0.0 **Test plan** `yarn lint` should pass. * chore(jest): Upgrade Jest flow types (#5573) **Summary** Follow up to #5569. **Test plan** `yarn lint` should pass without errors. * ci(appveyor): Fix AppVeyor tests (#5574) * ci(appveyor): Fix AppVeyor tests **Summary** Jest 22.4.x mocks the process object without a proper stub for `process.mainModule`. In our lifecycle code, we try to set `env.npm_execpath` when it is not defined by using `process.mainModule.filename`. When running tests on AppVeyor, we run Jest directly, thus we don't have `env.npm_execpath` set, triggering the `process.mainModule` code path which is also not set, causing tests to fail. **Test plan** AppVeyor builds should pass. * Fix tests * Add missing package cache * Bring --update-checksums back * Fix tests * Bring --update-checksums back * Fix Flow error * Fix error w/ updateChecksums * Update ssri semver in package.json * Stabilize TarballFetcher.fetch tests * Moar test fixes * test(update-checksums): make sure the flag works when integrity is malformed * fix(updateChecksums): minor issues and edge cases * Revert unrelated change ahead of 'imsnif/master' by 1 commit. * Slight refactor in lockfile parser * test(fixtures): update integrity and dep versions * fix(checksums): create integrity when importing from node_modules * test(fixtures): add integrity field to expected yarn.lock * Fixes error reporting * Fixes error reporting * Fixes tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #5569.
Test plan
yarn lintshould pass without errors.