Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generated .pnp.js compatibility with Node 6. #6871

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Fix generated .pnp.js compatibility with Node 6. #6871

merged 2 commits into from
Jan 4, 2019

Commits on Jan 3, 2019

  1. Fix generated .pnp.js compatibility with Node 6. 

    Prior to these changes the generated `.pnp.js` file would use trailing
commas for function invocations which is not allowed (and generates a
parse error) under Node 6.

This removes the offending trailing commas...
    @rwjblue
    rwjblue committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    7305948 View commit details
    Browse the repository at this point in the history

  2. Update lint config for src/util/generate-pnp-map-api.tpl.js. 

    This file does not get transpiled down for Node 4 compat like other
files, so we cannot use `"trailingComma": "all"` configuration (the
default prettier config for this repo).
    @rwjblue
    rwjblue committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    d6841b8 View commit details
    Browse the repository at this point in the history