Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): allow global-folder to be set in .yarnrc #7056

Merged
merged 4 commits into from
Feb 28, 2019
Merged

fix(config): allow global-folder to be set in .yarnrc #7056

merged 4 commits into from
Feb 28, 2019

Conversation

niheaven
Copy link
Contributor

Summary

Close #5637. Allow global-folder to be set in .yarnrc, and be used if --global-folder is not set. Fallback setting remain unchanged.

Test plan

yarn-patch

@arcanis arcanis merged commit 9fae32c into yarnpkg:master Feb 28, 2019
r15ch13 pushed a commit to ScoopInstaller/Scoop that referenced this pull request Mar 18, 2019
- Yarn's global folder can be set via `yarn config set global-folder` (yarnpkg/yarn#7056) and thus can be persisted. 
- ~~Since yarn's global bin creating procedure is still problematic (yarnpkg/yarn#6902, **fixed by yarnpkg/yarn#6954 The `.bin` folder in `global\node_modules` is a better path to add to env, and this can avoid the annoying problem when you install scoop in some place except `C:` (that the shims in global bin have wrong relative path pointer).
- If you install yarn via `scoop install yarn`, the `Yarn` folder in `$env:LOCALAPPDATA` is useless, and when you uninstall `yarn`, the `.yarnrc` is unused, so the manifest add `uninstaller.script` to remove them when you uninstall.
- For reconfiguration, please use `scoop update yarn -f` instead of `scoop reset yarn`.

- Close #2969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants