Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to security advisory #7091

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Fix link to security advisory #7091

merged 1 commit into from
Mar 8, 2019

Conversation

sonicdoe
Copy link
Contributor

@sonicdoe sonicdoe commented Mar 8, 2019

Summary

Fixes the link provided in the “More info” row when running yarn audit.

The Node Security Platform (nodesecurity.io) was acquired by npm in April 2018. nodesecurity.io/advisories is no longer available nowadays, however, all security advisories are available on npmjs.com/advisories.

Test plan

$ yarn audit
yarn audit v1.15.0-0
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ moderate      │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ lodash                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=4.17.11                                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ lodash                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ lodash                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://www.npmjs.com/advisories/782                         │
└───────────────┴──────────────────────────────────────────────────────────────┘
1 vulnerabilities found - Packages audited: 1
Severity: 1 Moderate
✨  Done in 3.74s.

Before, the defunct link https://nodesecurity.io/advisories/782 was printed. Now, it prints https://nodesecurity.io/advisories/782 in the “More info” row.

The Node Security Platform (nodesecurity.io) was acquired by npm in April 2018. https://nodesecurity.io/advisories is no longer available nowadays, however, all security advisories are available on https://www.npmjs.com/advisories.
@arcanis arcanis merged commit 379ed0a into yarnpkg:master Mar 8, 2019
@arcanis
Copy link
Member

arcanis commented Mar 8, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants