Resolves folder options (i.e. --modules-folder) relative to cwd (#7074) #7607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents potentially surprising behavior and data loss
Includes integration test verifying that user-reported data loss scenario does not occur
Summary
Motivated by high severity issue #7074, following recommended approach by @arcanis of resolving all folder options relative to the cwd (instead of potentially relative to the nearest project root). Adds an integration test illustrating there are no yarn failures, data loss, or other surprising behaviors in the scenario reported in the issue.
Test plan
It's relatively straightforward to reproduce the reported issue with a current version of yarn:
Running this shows the yarn command failing, but IMPORTANT.txt having been deleted from the project folder. This does not occur if yarn includes this patch.