Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force to use / as a path separator in yarn-path #7860

Closed
wants to merge 1 commit into from

Conversation

exKAZUu
Copy link

@exKAZUu exKAZUu commented Jan 31, 2020

Summary

Close #7777 Close yarnpkg/berry#858

\\ in yarn-path causes a problem where berry cannot be run on a non-Windows environment.
This PR forces to use / as a path separator in yarn-path even on Windows.

Test plan

Welcome to Node.js v13.3.0.
Type ".help" for more information.
> 'foo\\bar\\baz'.split(path.sep).join('/')
'foo/bar/baz'
> '\\foo\\bar\\baz'.split(path.sep).join('/')
'/foo/bar/baz'
> '\\foo\\bar\\baz\\'.split(path.sep).join('/')
'/foo/bar/baz/'
> '..\\foo\\bar\\baz\\'.split(path.sep).join('/')
'../foo/bar/baz/'

@exKAZUu exKAZUu requested a review from arcanis January 31, 2020 14:12
@exKAZUu exKAZUu changed the title fix: use / as a path separator in yarn-path fix: force to use / as a path separator in yarn-path Jan 31, 2020
@arcanis
Copy link
Member

arcanis commented Jan 31, 2020

Thanks! Fixed in #7862

@arcanis arcanis closed this Jan 31, 2020
@exKAZUu exKAZUu deleted the patch-1 branch January 31, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants