Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-hotkeys from 1.1.4 to 2.0.0 in /frontend #6

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Oct 20, 2020

Bumps react-hotkeys from 1.1.4 to 2.0.0.

Release notes

Sourced from react-hotkeys's releases.

v2.0.0

This release represents a complete re-write of the internals and much of the interface of react-hotkeys. Mousetrap has been removed as a dependency, and instead react-hotkeys works on the top of the React SyntheticEvent events system.

Upgrading from v1.*?

This release is the same as the v2.0.0-pre9 and these release notes contain a summary of the changes moving from v1.* to v2.0.0.

Upgrading from v2.0.0-pre*?

Ignore this set of release notes, and follow the notes for each each pre-release starting from the version you are using, up to v2.0.0-pre9.

Breaking Changes

__mousetrap__ is no longer available

Rather unsurprisingly, with the removal of Mousetrap, it's no longer possible to access the private Mousetrap instance to configure it. Many of the use-cases for needing to do so have been covered by API updates described below. If your use-case is not covered, however, please create a new issue.

HotKeyMapMixin has been removed

This was an internal part of react-hotkeys and is no longer used, and so it does not makes sense to continue to provide it.

FocusTrap has been removed

Similar to HotKeyMapMixin, this was an internal part of react-hotkeys and is no longer used, and so it does not makes sense to continue to provide it.

withHotKeys has been replaced

The old withHotKeys function has been repurposed and should not be used in the same way the old one was (more on this later). The old implementation is still available as deprecatedWithHotKeys, but it is no longer officially supported and will be removed in future versions.

Before:

import {withHotKeys} from 'react-hotkeys';
const ACTION_KEY_MAP = {
'changeColor': 'alt+c',
};
withHotKeys(ACTION_KEY_MAP)(HOCWrappedNode);

After (suggested):

You can write your own function or HoC that supplies the same keyMap to a component passed to it.

import {HotKeys} from 'react-hotkeys';
const ACTION_KEY_MAP = {
</tr></table>

... (truncated)

Commits
  • 600a196 📦 v2.0.0
  • 38104c8 🏷 Merge branch 'master' into dev_refactor
  • 9f7db65 📦 Version 2.0.0-pre9
  • 799849e 💬 💚 Rename test file to cover holding down command
  • d8e83cf 🐛 Fix #201: Always allow submatches for combinations involving command
  • 89fdc8b 👕 Address linting suggestions
  • a01a968 👓 Rename KeyEventStateManager to KeyEventStateArrayManager
  • 2102ee9 👓 Rename KeyEventRecordState to KeyEventState
  • 9cd1ace 👓 Rename KeyCombinationRecord to KeyCombination
  • 7dfe0ea 👓 Rename KeyCombinationHistory to KeyHistory
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Oct 20, 2020

The following labels could not be found: needs triage, infra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants