Extract device description and filesystem label #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
extract-device-description
branch
from
9b01d69
to
df55da5
Compare
joseivanlopez
force-pushed
the
extract-device-description
branch
from
df55da5
to
7e6e484
Compare
joseivanlopez
force-pushed
the
extract-device-description
branch
from
9d7c8b5
to
b67ea7d
Compare
joseivanlopez
changed the title
|
✔️ Internal Jenkins job #1148 successfully finished |
joseivanlopez
added a commit
to agama-project/agama
that referenced
this pull request
Mar 8, 2024
## Problem More information is required to properly represent the storage proposal result: * Device description * Filesystem label This is a follow-up of #1071. ## Solution Add new D-Bus interfaces `Device` , `Partition`, `LVM.LogicalVolume` and adapt `Filesystem` interface. This changes require yast/yast-storage-ng#1373. NOTE: This PR goes to a feature branch instead of master. ## Testing * Added unit tests * Tested manually
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Mar 19, 2024
As part of the Storage UI changes described at https://github.com/openSUSE/agama/blob/master/doc/storage_ui.md document, this PR aims to merge into master the changes already available in the `storage_ui` feature branch, which has been already tested and validated. Namely, * #1071 Added the following information to D-Bus: * The list of actions includes the SID of the affected device. * The partition table exports the unused slots. * The LVM devices (volume groups, physical volumes and logical volumes) are exported. * The block devices includes their start block and also indicates whether the device is encrypted. * The staging devices are exported. * #1079 Adapt the storage client to the changes in the D-Bus API and adapt `ProposalPage` component to read the information about the devices if needed. * #1082 Added new D-Bus interfaces `Device` , `Partition`, `LVM.LogicalVolume` and adapt `Filesystem` interface. It requires yast/yast-storage-ng#1373. * #1088 Replaced the `Planned Actions` section in the storage proposal for a `Result` one which presents how the storage would look after installation instead of just the list of actions. * #1090 Moved the space policy configuration to a popup. * #1098 Replace a `Resize` by `Before` label as it was suggested during the presentation of the UI in a review meeting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The partitioner implements some logic to generate the content of the columns (e.g., for generating the descrition of the device, the label of a file system, etc). Such information is useful for other projects like Agama, but reusing that logic is not possible as it is because it is directly implemented in the partitioner columns (UI stuff).
Solution
Extract the logic for generating useful information to separate classes, making possible to reuse it.
Testing