-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to allow more flexible resize of partitions (needed by Agama) #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancorgs
force-pushed
the
agama_resize
branch
from
September 18, 2024 12:24
646dc77
to
2604a81
Compare
ancorgs
force-pushed
the
agama_resize
branch
3 times, most recently
from
September 19, 2024 13:38
a36b6b6
to
8e48662
Compare
ancorgs
changed the title
Some draft stuff for handling resize of partitions at the Agama proposal
Improvements to allow more flexible resize of partitions (needed by Agama)
Sep 19, 2024
ancorgs
force-pushed
the
agama_resize
branch
from
September 19, 2024 15:21
8e48662
to
690bcda
Compare
ancorgs
force-pushed
the
agama_resize
branch
2 times, most recently
from
September 20, 2024 07:57
fd0e879
to
65456bb
Compare
ancorgs
force-pushed
the
agama_resize
branch
from
September 20, 2024 08:05
65456bb
to
77100fa
Compare
joseivanlopez
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✅ Autosubmission job #10960612063 successfully finished |
ancorgs
added a commit
to agama-project/agama
that referenced
this pull request
Sep 20, 2024
joseivanlopez#1 documented the approach to follow for resizing partitions at Agama, based on the partitioning config (a.k.a. the "profile"). The current pull request implements the basis of the described management. It depends on the improvements introduced at yast2-storage-ng by yast/yast-storage-ng#1388 ### Pending Some aspects of partition growing are not fully handled. That's planned for a future iteration and documented at https://trello.com/c/opInsicQ/531-storage-profile-partition-growing
ancorgs
added a commit
to agama-project/agama
that referenced
this pull request
Sep 22, 2024
yast/yast-storage-ng#1388 introduced a change in the API of Y2Storage. Agama was adapted at #1599, but one particular conversion was left behind. This PR fixes that omission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agama allows to specify what to do with the existing partitions during installation in a quite flexible way. That includes deleting, deleting if needed or resizing (both shrinking and growing) within certain min and max sizes.
The initial support for that is implemented at agama-project/agama#1599
This pull request includes all the changes needed to make that implementation possible.