Cleanup Todos in input.fs #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjohnson338
commented
Aug 4, 2021
| @@ -218,8 +218,7 @@ let (|Mouse|Special|Normal|ImeEvent|TextInput|Unrecognized|) (x: InputEvent) = | |||
| | Key(_, Key.Add) -> Special("kPlus") | |||
| | Key(_, Key.Subtract) -> Special("kMinus") | |||
| | Key(_, Key.Divide) -> Special("kDivide") | |||
| // TODO| Key(_, Key.Decimal) -> ??? | |||
There was a problem hiding this comment.
This looks to be covered by line 187.
There was a problem hiding this comment.
must've been abandoned in the first run, then added later ;)
yatli
requested changes
Aug 15, 2021
| @@ -218,8 +218,7 @@ let (|Mouse|Special|Normal|ImeEvent|TextInput|Unrecognized|) (x: InputEvent) = | |||
| | Key(_, Key.Add) -> Special("kPlus") | |||
| | Key(_, Key.Subtract) -> Special("kMinus") | |||
| | Key(_, Key.Divide) -> Special("kDivide") | |||
| // TODO| Key(_, Key.Decimal) -> ??? | |||
| // TODO| Key(_, Key.Separator) -> ??? | |||
| | Key(_, Key.Separator) -> Special("Bar") | |||
There was a problem hiding this comment.
this one I'm not sure.
see: https://github.com/AvaloniaUI/Avalonia/search?q=Key.Separator
There was a problem hiding this comment.
according to this thread: https://stackoverflow.com/questions/36666868/uk-keyboard-virtual-key-code-for-the-symbol
Key.Separator is the "Enter" key on a numpad and I don't even have a numpad to test it 😂
Maybe map to <kEnter>.
There was a problem hiding this comment.
and maybe Key.Decimal to <kPoint>?
|
and thanks for cleaning this up! |
|
@jjohnson338 I've also cleaned up the keypad mappings (0efa44b) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a swing at cleaning up a couple of TODOs found in the
input.fsfile.