Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular.js-based management portal for Geofencing #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

antonba
Copy link

@antonba antonba commented Oct 24, 2013

Please check that there isn't additional stuff to the portal because I see commits to Geofencing/Data/Starbucks.txt and Geofencing/Data/Starbucks - cut.txt that I haven't made.

@@ -0,0 +1,1245 @@
/*!
* Bootstrap Responsive v2.3.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change to use the versions of the libs from the CDNs?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreee... it makes it very hard to review the diff.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template I used came with a different bootstrap file; also I may have modified it too; what's the issue? the portal is self-contained...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a lot of extra code that is not strictly necessary. I got it to (mostly) work with no local 3rd party files, using the CDN ones:

<link rel="stylesheet" href="//netdna.bootstrapcdn.com/bootstrap/2.3.2/css/bootstrap.min.css">
<script src='https://whatsnear.azure-mobile.net/client/MobileServices.Web-1.0.0.min.js'></script>
<script src='https://ajax.aspnetcdn.com/ajax/jQuery/jquery-2.0.3.min.js'></script>
<script src="//netdna.bootstrapcdn.com/bootstrap/2.3.2/js/bootstrap.min.js"></script>
<script src="//ajax.googleapis.com/ajax/libs/angularjs/1.0.7/angular.min.js"></script>
<script src="//ajax.googleapis.com/ajax/libs/angularjs/1.0.7/angular-resource.min.js"></script>

@jcookems
Copy link
Contributor

Remove the Starbucks-Cut.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants