sync #1
Merged
sync #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a checkbox-type question is saved multiple times, the values in the database containing an ampersand are converted to & and the Edit Information UI comparison no longer works. The escaping is a separate bug, but to fix the UI for existing data let's compare to an array of escaped values in addition to the ones originally stored. Fixes #144
Fixes https://hackerone.com/reports/164793 Props https://hackerone.com/grande for coordinating disclosure
Fixes https://hackerone.com/reports/164674 Props https://hackerone.com/grande for coordinating disclosure Fixes https://hackerone.com/reports/160520 Props https://hackerone.com/lalka for coordinating disclosure
Fixes https://hackerone.com/reports/160500 Props https://hackerone.com/white_walker for coordinating disclosure
This clutters the screen with lots of unnecessary info. If this functionality is desired, it should be implemented in a cleaner and more user-friendly/developer-friendly way.
Not all sites will use the built-in field, and newer ones may not have opened ticket sales yet, so only querying for 50 sites is not enough.
A large attendee list causes a large number of concurrent requests to be sent from the browser to Gravatar, which bogs down the page loading performance. This inserts a placeholder element for all the attendee avatars when rendering the HTML markup. A jQuery plugin called Appear is then used to detect when a placeholder element is about to scroll into view, which triggers an event that replaces the placeholder element with an img tag, using a JS template. Jetpack's jquery.spin script is used to provide a visual indicator that an avatar is in the process of loading. Refs https://meta.trac.wordpress.org/ticket/1760
* Attendees shortcode: Refactor caching of attendees lists This refactors the way that the shortcode content is generated, splitting the functionality into several smaller methods so that the content can be generated and cached in a separate cronjob as well as when the shortcode callback is fired. * Clean up indentation and spacing * Add missing doc blocks to action hooks * Add note explaining removal of cache backcompat See #158 (comment) * Attendees shortcode: More caching improvements * Allow outdated cache content to be shown for non-cronjob requests to avoid long page loads for site visitors * Run the caching cronjob for archived sites, since the cache can still be invalidated, but at a much longer interval.
In response to error message: E_WARNING: ..camptix/addons/shortcodes.php:103 - preg_match_all(): Delimiter must not be alphanumeric or backslash
This attempts to resolve the following error: PHP Warning: Invalid argument supplied for foreach() in /home/wordcamp/public_html/wp-content/plugins/camptix/ addons/field-twitter.php on line 36 When the shortcode functionality was refactored to change the way it cached the attendees list content, a regression was introduced because there were some cases where the `camptix_attendees_shortcode_init` action was not called during the markup rendering, which caused some other addon code to throw errors like the above. This ensures the action is always fired during content rendering.
Note: This was rebased and force-pushed by @iandunn several weeks after the initial push, in order to clean up the commit history. Previous commit hashes: 8da7b0c v.1.5.1 > New pot + French l10n update 24e63ac Typo a5dcd2e typo 924e15e more typo 63a5378 This time is my turn to introduce some typos 5ff65cb l10n improvement 82e72ae Typo: missed a plural form d5eed8f fixing a non sense in original string 0e4f846 Recompile camptix-fr_FR.mo bf5448f Add support for language packs d58830d Remove extra text domain logic
Add support for language packs
Locales that have language packs shouldn't have a bundled translation because it will override the language pack, which is much easier to keep up to date. See: https://translate.wordpress.org/projects/wp-plugins/camptix/language-packs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.