(xmlsec-gcrypt) Fix double free in xmlSecGCryptAsymKeyDataGenerate (l…

…sh123#795)
ycharts · May 17, 2024 · 243afff · 243afff
1 parent c866f7f
commit 243afff
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/gcrypt/asymkeys.c b/src/gcrypt/asymkeys.c
@@ -182,6 +182,9 @@ xmlSecGCryptAsymKeyDataAdoptKey(xmlSecKeyDataPtr data, gcry_sexp_t key_pair) {
     pub_key = NULL; /* data owns it now */
     priv_key = NULL; /* data owns it now */
 
+   /* Adopt functions assume ownership on success thus the caller would expect this to be released */
+    gcry_sexp_release(key_pair);
+
     /* success */
     res = 0;
 
@@ -194,9 +197,6 @@ xmlSecGCryptAsymKeyDataAdoptKey(xmlSecKeyDataPtr data, gcry_sexp_t key_pair) {
         gcry_sexp_release(priv_key);
     }
 
-    /* Adopt functions assume ownership thus the caller would expect this to be released */
-    gcry_sexp_release(key_pair);
-
     /* done */
     return(res);
 }