Add Go To features for python #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a Go To Definition and Go To Declaration features for python.
|
|
||
| def _JumpToLocation( self, definition_list ): | ||
| if len( definition_list ) == 1: | ||
| definition = list( definition_list )[0] |
There was a problem hiding this comment.
Why are you wrapping it in list()?
There was a problem hiding this comment.
My bad, forgot to remove this. goto() and get_definition() returns a list so type casting is not needed.
|
This is good, thanks. Implement |
|
Should be good now. Still need to update docs though. |
| def _GoToDefinition( self ): | ||
| definitions = self._GetDefinitionsList() | ||
| if definitions: | ||
| self._JumpToLocation(definitions) |
There was a problem hiding this comment.
Space after ( and before ) (except when empty parens). Same for other locations.
|
This was a great pull, thanks! |
|
Glad to help :) |
bijancn
pushed a commit
to bijancn/YouCompleteMe
that referenced
this pull request
Jul 26, 2016
… r=Valloric Improves semantic trigger match. Improves semantic trigger match. Match triggers until user's caret column solely. Trying to match triggers with characters after user's caret column doesn't seem to have any utility. --- This is the first in a series of pull-requests that will transparently enable ycm-core#1300 for any completer that cares for. After this minimal foundation is stablished, an initial Swift completer will be available, supporting diagnostics, fix-it's, semantic completion and argument hints. Changes will also be proposed to enable hints for C and C++. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/292) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Go To Definition and Go To Declaration for python. Jedi has a 2 goto functions, they are well documented. Basically,
get_definitionacts more like go to declaration, whilegotoacts like go to definition.Since both methods can return multiple definitions we need to pass all of them to the user, so he can make a decision. This is done by opening a quickfix window with a
youcompleteme#OpenGoToListmethod.