-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YCM runs on large-ish non-source files, spews a backtrace when you enter insert mode #476
Comments
I expected this to happen when the file is around 1Mb, which is the max size of a request that we set for Bottle, but if you can reproduce this with a 500Kb then the problem could be something else 😕 Can you post the ycmd logs as well? |
Sure, where can I find the ycmd logs? |
|
OK, looks just like the stack trace I got above.
|
Actually the command didn't work an you got the same error as before. What you shoul do is:
|
If I do this, I still get the same stacktrace. OTOH if I invert the order of these operations, I get the following in my stderr log. The stdout log is empty.
|
@jlebar Since I see references to |
I wonder if I'm saving anyone time by doing all this testing myself? Like, if others cannot reproduce, I would be happy to dig in and try to figure out what is interesting about my config, but otherwise if I can reproduce using the public build, well, the next step is going to be for someone else to reproduce it themselves... Unless you think this is likely to be something unusual about my config? |
By all means, please do. :)
True, but issue reporters are rarely willing to run through the code to figure out the issue. :) Also, we tend to know the codebase pretty well. If we could repro it, we could probably figure out the root cause faster and with less hassle. But hey, if you're willing to dig through the code on this, count us happy. :) |
I'm not sure where you got that I was volunteering to dig through the code? Sorry, I must have been unclear. All I was asking is for someone else to try to reproduce this bug, before asking me to spend half an hour configuring YCM on a new machine. If that's too much to ask, I'll go away, with sincere apologies for wasting everyone's time. |
I can repro with stock YCM on my mac at head. Exact same behavior. Server stderr: Otherwise the exact same output as @jlebar. :YcmDebugInfo |
I'll look into this |
[READY] Return a proper response when the request is too big. We have a hard limit on the size of the request that ycmd can handle that is set to 1Mb. This is dictated by Bottle and there is no way around it. #### Why is this a problem: When a client makes a request greater than 1Mb Bottle returns an error that is not generated by us and thus it is not a json response, but an html one, and it doesn't contain the HMAC header which causes errors like #476. For now I've pushed only the failing test. Once I see it fail on Travis I will push the fix. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/482) <!-- Reviewable:end -->
STR:
Now enter insert mode.
Result: YCM error spew, included below.
I bisected the test file size and noticed that the error starts occurring somewhere between files of size 100k and 300k.
+@r4nt
The text was updated successfully, but these errors were encountered: