Java: Fix gradle project root detection

[puremourning]

Typical "modern" layout from gradle init:

• settings.gradle
• app/build.gradle
• ...

If you open app/src/java/.../Foo.java, we incorrectly pick app/ as the project root because we find first build.gradle then keep looking only for that file. Instead we should keep looking for any gradle file.

Now, when searching for the project root, we continue to search the varioius file names, but we tag each file name with the "kind" and keep searching for other files of the same kind rather than just the same name.

Meanwhile, we prefer finding the gradle/maven project. The reason for this is that jdt.ls spams .project files all over the codebase which makes any project you've previously opened look like an eclipse project. This is fine if the project root was previously correctly determined and/or the projects properly imported, but means that we never self-correct. So prefer finding the non-native project types so that we pick the correct root in most cases.

---

This change is 

[puremourning]

Reviewable status: 0 of 2 LGTMs obtained

---

ycmd/completers/java/java_completer.py line 45 at r1 (raw file):

PATH_TO_JAVA = None

PROJECT_FILE_TAILS = {

making this a dictionary makes the sequence undefined. Either revert to list or use OrderedDict.

[puremourning]

Reviewable status: 0 of 2 LGTMs obtained

---

ycmd/completers/java/java_completer.py line 45 at r1 (raw file):

Previously, puremourning (Ben Jackson) wrote…

making this a dictionary makes the sequence undefined. Either revert to list or use OrderedDict.

done

[puremourning]

Added a test using bare grade init project

Reviewable status: 0 of 2 LGTMs obtained

[puremourning]

Reviewed 26 of 26 files at r2, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @puremourning)

[bstaletic]

Reviewed 26 of 26 files at r2, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @puremourning)

---

ycmd/completers/java/java_completer.py line 45 at r1 (raw file):

Previously, puremourning (Ben Jackson) wrote…

done

Iteration order of regular dictionaries is defined to be the same as insertion order, since... python 3.7. We only support python 3.8 and newer and even python 3.8 is nearing EOL.

https://mail.python.org/pipermail/python-dev/2017-December/151283.html

A list of tuples is an odd data type, when dict works. If you think we should be more explicit about ordering, then there's still OrderedDict.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (5de7052) to head (779a711).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
+ Coverage   95.92%   95.94%   +0.02%     
==========================================
  Files          84       84              
  Lines        8462     8464       +2     
  Branches      163      163              
==========================================
+ Hits         8117     8121       +4     
+ Misses        295      293       -2     
  Partials       50       50              

[bstaletic]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @puremourning)

[mergify]

Thanks for sending a PR!

[mergify]

Thanks for sending a PR!