Skip to content

Commit

Permalink
fix: design fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
astandrik committed Sep 16, 2024
1 parent 2256288 commit 21c1e4c
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 17 deletions.
14 changes: 0 additions & 14 deletions src/components/StorageGroupInfo/StorageGroupInfo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ interface StorageGroupInfoProps extends Omit<InfoViewerProps, 'info'> {
// eslint-disable-next-line complexity
export function StorageGroupInfo({data, className, ...infoViewerProps}: StorageGroupInfoProps) {
const {
GroupId,
PoolName,
Encryption,
Overall,
DiskSpace,
Expand All @@ -47,24 +45,12 @@ export function StorageGroupInfo({data, className, ...infoViewerProps}: StorageG

const storageGroupInfoFirstColumn = [];

if (valueIsDefined(GroupId)) {
storageGroupInfoFirstColumn.push({
label: storageGroupInfoKeyset('group-id'),
value: GroupId,
});
}
if (valueIsDefined(GroupGeneration)) {
storageGroupInfoFirstColumn.push({
label: storageGroupInfoKeyset('group-generation'),
value: GroupGeneration,
});
}
if (valueIsDefined(PoolName)) {
storageGroupInfoFirstColumn.push({
label: storageGroupInfoKeyset('pool-name'),
value: PoolName,
});
}
if (valueIsDefined(ErasureSpecies)) {
storageGroupInfoFirstColumn.push({
label: storageGroupInfoKeyset('erasure-species'),
Expand Down
1 change: 0 additions & 1 deletion src/components/StorageGroupInfo/i18n/en.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"group-id": "Group ID",
"pool-name": "Pool Name",
"encryption": "Encryption",
"overall": "Overall",
Expand Down
4 changes: 4 additions & 0 deletions src/containers/StorageGroupPage/StorageGroupPage.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
left: 0;
}

&__info {
margin-top: var(--g-spacing-10);
}

&__controls {
display: flex;
align-items: center;
Expand Down
2 changes: 1 addition & 1 deletion src/containers/StorageGroupPage/StorageGroupPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export function StorageGroupPage() {
return null;
}

const items = [`${storageGroupPageKeyset('storage-group')}: ${groupId}`];
const items = [`${storageGroupPageKeyset('pool-name')}: ${storageGroupData?.PoolName}`];

return (
<PageMetaWithAutorefresh
Expand Down
3 changes: 2 additions & 1 deletion src/containers/StorageGroupPage/i18n/en.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"storage-group": "Storage Group",
"group": "Group",
"nodes": "Nodes"
"nodes": "Nodes",
"pool-name": "Pool Name"
}

0 comments on commit 21c1e4c

Please sign in to comment.