feat(Nodes): add node name column (#1385)

ydb-platform · Oct 2, 2024 · a4c24e1 · a4c24e1
1 parent 5f26767
commit a4c24e1
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 0 deletions.
diff --git a/src/containers/Nodes/columns/columns.tsx b/src/containers/Nodes/columns/columns.tsx
@@ -36,6 +36,13 @@ const getHostColumn = (getNodeRef?: GetNodeRefFunc, database?: string): NodesCol
     align: DataTable.LEFT,
     sortable: false,
 });
+const nodeNameColumn: NodesColumn = {
+    name: NODES_COLUMNS_IDS.NodeName,
+    header: NODES_COLUMNS_TITLES.NodeName,
+    align: DataTable.LEFT,
+    render: ({row}) => row.NodeName || EMPTY_DATA_PLACEHOLDER,
+    width: 200,
+};
 
 const getHostColumnWithUndefinedWidth = (
     getNodeRef?: GetNodeRefFunc,
@@ -217,6 +224,7 @@ export function getNodesColumns({database, getNodeRef}: GetNodesColumnsProps): N
     const columns = [
         nodeIdColumn,
         getHostColumn(getNodeRef, database),
+        nodeNameColumn,
         dataCenterColumn,
         rackColumn,
         versionColumn,

diff --git a/src/containers/Nodes/columns/constants.ts b/src/containers/Nodes/columns/constants.ts
@@ -8,6 +8,7 @@ export const NODES_TABLE_SELECTED_COLUMNS_LS_KEY = 'nodesTableSelectedColumns';
 export const NODES_COLUMNS_IDS = {
     NodeId: 'NodeId',
     Host: 'Host',
+    NodeName: 'NodeName',
     DC: 'DC',
     Rack: 'Rack',
     Version: 'Version',
@@ -48,6 +49,9 @@ export const NODES_COLUMNS_TITLES = {
     get Host() {
         return i18n('host');
     },
+    get NodeName() {
+        return i18n('node-name');
+    },
     get DC() {
         return i18n('dc');
     },

diff --git a/src/containers/Nodes/columns/i18n/en.json b/src/containers/Nodes/columns/i18n/en.json
@@ -1,6 +1,7 @@
 {
   "node-id": "Node Id",
   "host": "Host",
+  "node-name": "Node Name",
   "dc": "DC",
   "rack": "Rack",
   "version": "Version",

diff --git a/src/store/reducers/nodes/types.ts b/src/store/reducers/nodes/types.ts
@@ -11,6 +11,7 @@ import type {ProblemFilterValue} from '../settings/types';
 export interface NodesPreparedEntity {
     NodeId: number;
     Host?: string;
+    NodeName?: string;
     SystemState?: EFlag;
     DC?: string;
     Rack?: string;

diff --git a/src/types/api/nodes.ts b/src/types/api/nodes.ts
@@ -86,6 +86,7 @@ export interface TSystemStateInfo {
 
     SharedCacheStats?: TNodeSharedCache;
     TotalSessions?: number;
+    NodeName?: string;
 }
 
 export type PoolName = 'System' | 'User' | 'Batch' | 'IO' | 'IC';