fix: update links to VDisk and PDisk Developer UI #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
add-pdisk-link
branch
from
67c75a1
to
f328b6e
Compare
Raubzeug
previously approved these changes
Nov 14, 2023
| pDiskId, | ||
| vDiskSlotId, | ||
| }: VDiskDeveloperUILinkParams) => { | ||
| const vdiskPath = 'actors/vdisks/vdisk' + pad9(pDiskId) + '_' + pad9(vDiskSlotId); |
There was a problem hiding this comment.
Maybe format string will be better?
There was a problem hiding this comment.
As for me, current form is more explicit. I don't like formatted strings with symbols, because symbols are visually lost (_ in this case)
const vdiskPath = `actors/vdisks/vdisk${pad9(pDiskId)}_${pad9(vDiskSlotId)}`;
| } | ||
|
|
||
| export const createPDiskDeveloperUILink = ({nodeId, pDiskId}: PDiskDeveloperUILinkParams) => { | ||
| const pdiskPath = 'actors/pdisks/pdisk' + pad9(pDiskId); |
There was a problem hiding this comment.
Maybe format string will be better?
| } | ||
|
|
||
| return ( | ||
| <div className={b('vdisk-id', {selected: row.id === selectedVdiskId})}> | ||
| <span>{row.VDiskSlotId}</span> | ||
| <span>{vDiskSlotId}</span> | ||
| {vdiskInternalViewerLink && ( | ||
| <Button |
There was a problem hiding this comment.
Button here and in VDisk are without text. Lets add title to provide more accessibility.
Raubzeug
approved these changes
Nov 14, 2023
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update links to PDIsk and VDisk DeveloperUI. They are no longer uses external logic and are always present.
Links are formed based on current backend (node host with embedded-ui), they use clusters nodes ability to connect with each other.
{backend}/node/{tagetNodeId}/path