-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update links to VDisk and PDisk Developer UI #582
Conversation
67c75a1
to
f328b6e
Compare
pDiskId, | ||
vDiskSlotId, | ||
}: VDiskDeveloperUILinkParams) => { | ||
const vdiskPath = 'actors/vdisks/vdisk' + pad9(pDiskId) + '_' + pad9(vDiskSlotId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe format string will be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for me, current form is more explicit. I don't like formatted strings with symbols, because symbols are visually lost (_
in this case)
const vdiskPath = `actors/vdisks/vdisk${pad9(pDiskId)}_${pad9(vDiskSlotId)}`;
} | ||
|
||
export const createPDiskDeveloperUILink = ({nodeId, pDiskId}: PDiskDeveloperUILinkParams) => { | ||
const pdiskPath = 'actors/pdisks/pdisk' + pad9(pDiskId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe format string will be better?
} | ||
|
||
return ( | ||
<div className={b('vdisk-id', {selected: row.id === selectedVdiskId})}> | ||
<span>{row.VDiskSlotId}</span> | ||
<span>{vDiskSlotId}</span> | ||
{vdiskInternalViewerLink && ( | ||
<Button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Button here and in VDisk are without text. Lets add title to provide more accessibility.
Update links to PDIsk and VDisk DeveloperUI. They are no longer uses external logic and are always present.
Links are formed based on current backend (node host with embedded-ui), they use clusters nodes ability to connect with each other.
{backend}/node/{tagetNodeId}/path