-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update links to VDisk and PDisk Developer UI #582
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"pdisk.developer-ui-button-title": "PDisk Developer UI page", | ||
"vdisk.developer-ui-button-title": "VDisk Developer UI page" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import {i18n, Lang} from '../../../utils/i18n'; | ||
|
||
import en from './en.json'; | ||
import ru from './ru.json'; | ||
|
||
const COMPONENT = 'ydb-node-page'; | ||
|
||
i18n.registerKeyset(Lang.En, COMPONENT, en); | ||
i18n.registerKeyset(Lang.Ru, COMPONENT, ru); | ||
|
||
export default i18n.keyset(COMPONENT); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"pdisk.developer-ui-button-title": "Страница PDisk в Developer UI", | ||
"vdisk.developer-ui-button-title": "Страница VDisk в Developer UI" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import {backend} from '../store'; | ||
import {pad9} from './utils'; | ||
|
||
// Current node connects with target node by itself using nodeId | ||
export const createDeveloperUILinkWithNodeId = (nodeId: number | string) => { | ||
return `${backend}/node/${nodeId}/`; | ||
}; | ||
|
||
interface PDiskDeveloperUILinkParams { | ||
nodeId: number | string; | ||
pDiskId: number | string; | ||
} | ||
|
||
export const createPDiskDeveloperUILink = ({nodeId, pDiskId}: PDiskDeveloperUILinkParams) => { | ||
const pdiskPath = 'actors/pdisks/pdisk' + pad9(pDiskId); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe format string will be better? |
||
|
||
return createDeveloperUILinkWithNodeId(nodeId) + pdiskPath; | ||
}; | ||
|
||
interface VDiskDeveloperUILinkParams extends PDiskDeveloperUILinkParams { | ||
vDiskSlotId: number | string; | ||
} | ||
|
||
export const createVDiskDeveloperUILink = ({ | ||
nodeId, | ||
pDiskId, | ||
vDiskSlotId, | ||
}: VDiskDeveloperUILinkParams) => { | ||
const vdiskPath = 'actors/vdisks/vdisk' + pad9(pDiskId) + '_' + pad9(vDiskSlotId); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe format string will be better? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As for me, current form is more explicit. I don't like formatted strings with symbols, because symbols are visually lost ( |
||
|
||
return createDeveloperUILinkWithNodeId(nodeId) + vdiskPath; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Button here and in VDisk are without text. Lets add title to provide more accessibility.