-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Query): enable queries with multiple resultsets #595
Conversation
d39a381
to
8f58972
Compare
{isFullscreen && ( | ||
<Fullscreen> | ||
<div className={b('result', {fullscreen: true})}>{result}</div> | ||
<div className={b('result-fullscreen-wrapper')}>{renderContent()}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We render content here and in 158 line. Is it possible to optimise this?
And we should think about optimisation work with Fullscreen. It seems that it's no need to render Fullscreen always. I remember that there're a lot of pitfalls with it, but maybe we need this issue in backlog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll put it to a variable.
Could you please clarify what is the problem with Fullscreen
and how it could be optimised?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, Fullscreen
is always rendered, no matter if user wanted to see it at least one time or not. And its content may be quite heavy to render. So I suggest to improve it with the same technology as we discussed regarding Tabs content!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I get it, added this issue to ticket with QueryEditor
optimisation
Use
multi
schema for requests if setting is enabled. It allows queries with multiple result set. Query example:In this case tabs with result sets will appear above result table