Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Query): enable queries with multiple resultsets #595

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Nov 23, 2023

Use multi schema for requests if setting is enabled. It allows queries with multiple result set. Query example:

SELECT * FROM `/table1`;
SELECT * FROM `/table2`;
SELECT * FROM `/table3`;

In this case tabs with result sets will appear above result table
Screen Shot 2023-11-23 at 14 42 14

@artemmufazalov artemmufazalov marked this pull request as ready for review November 23, 2023 13:21
{isFullscreen && (
<Fullscreen>
<div className={b('result', {fullscreen: true})}>{result}</div>
<div className={b('result-fullscreen-wrapper')}>{renderContent()}</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We render content here and in 158 line. Is it possible to optimise this?
And we should think about optimisation work with Fullscreen. It seems that it's no need to render Fullscreen always. I remember that there're a lot of pitfalls with it, but maybe we need this issue in backlog.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put it to a variable.

Could you please clarify what is the problem with Fullscreen and how it could be optimised?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, Fullscreen is always rendered, no matter if user wanted to see it at least one time or not. And its content may be quite heavy to render. So I suggest to improve it with the same technology as we discussed regarding Tabs content!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I get it, added this issue to ticket with QueryEditor optimisation

src/utils/query.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants