feat: add view to schema #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
add-view-to-schema
branch
from
c632f5d
to
805e828
Compare
artemmufazalov
commented
May 21, 2024
| @@ -10,15 +10,16 @@ | |||
|
|
|||
| "actions.copied": "The path is copied to the clipboard", | |||
| "actions.notCopied": "Couldn’t copy the path", | |||
| "actions.externalTableSelectUnavailable": "Select query for external tables available only with 'YQL - QueryService' query mode. You need to turn in additional query modes in settings to enable it", | |||
There was a problem hiding this comment.
Now we display all possible modes by default
artemmufazalov
commented
May 21, 2024
| @@ -10,7 +10,7 @@ import type {EPathType} from '../../../../types/api/schema'; | |||
| import {cn} from '../../../../utils/cn'; | |||
| import {useTypedDispatch, useTypedSelector} from '../../../../utils/hooks'; | |||
| import {prepareQueryError} from '../../../../utils/query'; | |||
| import {isExternalTable, isTableType} from '../../utils/schema'; | |||
| import {isExternalTableType, isTableType} from '../../utils/schema'; | |||
There was a problem hiding this comment.
Just renamed some helpers
Raubzeug
approved these changes
May 22, 2024
artemmufazalov
force-pushed
the
add-view-to-schema
branch
from
805e828
to
42168dd
Compare
Raubzeug
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #784
Schema and Info tabs will be supported in #785
Test stand: https://nda.ya.ru/t/iuqE5xQN7625YN