Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Nodes): better memory bars #1091

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix(Nodes): better memory bars #1091

merged 2 commits into from
Aug 2, 2024

Conversation

kunga
Copy link
Member

@kunga kunga commented Jul 30, 2024 •
edited
Loading

Changes

  • Render memory without a limit as full
  • Use bars for memory in Nodes list
  • Render Caches instead of Tablet Caches and Query Runtime
  • Render values with formatStorageValuesToGb instead of formatBytesToGigabyte for better precision

Before

image

After

image

Before

image

After

image

@kunga kunga mentioned this pull request Jul 30, 2024
Merged
@artemmufazalov artemmufazalov merged commit 87f2b92 into ydb-platform:main Aug 2, 2024
5 checks passed
@ydb-platform-bot ydb-platform-bot mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemmufazalov artemmufazalov artemmufazalov approved these changes

Assignees

@kunga kunga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunga @artemmufazalov