-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PDiskPage): add decommission button #1168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
1092-pdisk-decomission
branch
4 times, most recently
from
August 22, 2024 13:21
dcc572b
to
f334fea
Compare
artemmufazalov
force-pushed
the
1092-pdisk-decomission
branch
from
August 28, 2024 08:50
f334fea
to
f4b5be7
Compare
astandrik
requested changes
Aug 28, 2024
src/containers/PDiskPage/DecommissionButton/DecommissionButton.tsx
Outdated
Show resolved
Hide resolved
src/containers/PDiskPage/DecommissionButton/DecommissionButton.tsx
Outdated
Show resolved
Hide resolved
src/containers/PDiskPage/DecommissionButton/DecommissionButton.tsx
Outdated
Show resolved
Hide resolved
src/containers/PDiskPage/DecommissionButton/DecommissionButton.tsx
Outdated
Show resolved
Hide resolved
artemmufazalov
force-pushed
the
1092-pdisk-decomission
branch
from
September 3, 2024 14:00
f4b5be7
to
c231322
Compare
astandrik
reviewed
Sep 3, 2024
@@ -96,7 +101,33 @@ export function PDiskPage() { | |||
return undefined; | |||
}; | |||
|
|||
const handleAfterRestart = () => { | |||
const handleDecommissionChange = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const handleDecommissionChange = async (
newDecommissionStatus?: EDecommitStatus,
isRetry?: boolean
): Promise<void | undefined> => {
if (!pDiskParamsDefined) {
return undefined;
}
try {
const response = await window.api.changePDiskStatus({
nodeId,
pDiskId,
force: isRetry,
decommissionStatus: newDecommissionStatus,
});
if (response?.result === false) {
const err = {
statusText: response.error,
retryPossible: response.forceRetryPossible,
};
throw err;
}
} catch (error) {
// Re-throw the error to be handled by the caller
throw error;
}
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I didn't get your point. Your version looks more aligned with our codebase
astandrik
previously approved these changes
Sep 3, 2024
artemmufazalov
force-pushed
the
1092-pdisk-decomission
branch
from
September 4, 2024 13:09
c231322
to
e110c3c
Compare
astandrik
previously approved these changes
Sep 4, 2024
artemmufazalov
force-pushed
the
1092-pdisk-decomission
branch
from
September 4, 2024 15:51
e110c3c
to
e54080a
Compare
astandrik
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1092
Test stand: https://nda.ya.ru/t/FBNWq_Uf77bWwM
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 78.91 MB | Main: 78.88 MB
Diff: +0.03 MB (0.04%)
ℹ️ CI Information