feat: add storage group page #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested changes
Sep 12, 2024
astandrik
force-pushed
the
astandrik.add-storage-group-page-1159
branch
from
0f71f28
to
6e0eeb4
Compare
|
A bug when scrolling: 
|
Raubzeug
requested changes
Sep 17, 2024
| if (valueIsDefined(LatencyPutTabletLog)) { | ||
| storageGroupInfoSecondColumn.push({ | ||
| label: storageGroupInfoKeyset('latency-put-tablet-log'), | ||
| value: `${LatencyPutTabletLog} ms`, |
There was a problem hiding this comment.
Here and farther lets add spaces between the digits of the number (like it is done in Available Space field)
| } | ||
|
|
||
| return ( | ||
| <div className={b('wrapper', className)}> |
|
|
||
| return ( | ||
| <div className={b('wrapper', className)}> | ||
| <div className={b('col')}> |
| }; | ||
|
|
||
| return ( | ||
| <div className={storageGroupPageCn()}> |
Raubzeug
approved these changes
Sep 17, 2024
artemmufazalov
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stand
Closes #1159
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 78.96 MB | Main: 78.84 MB
Diff: +0.12 MB (0.15%)
ℹ️ CI Information