fix: do not hide pdisk and vdisk popups if mouse on popup content #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, change PR title prefix to |
artemmufazalov
previously approved these changes
Oct 10, 2024
|
@artemmufazalov added debounce cancelation to prevent appearing not needed popups on fast mast movement |
astandrik
changed the title
artemmufazalov
previously approved these changes
Oct 10, 2024
astandrik
force-pushed
the
astandrik.do-not-hide-pdisk-and-vdisk-popups-1360
branch
from
6ce9c94
to
00301ed
Compare
|
@Raubzeug added delay for table cells as discussed |
|
Deployed stand for testing |
Raubzeug
requested changes
Oct 10, 2024
| @@ -70,6 +70,14 @@ export const PDiskPopup = ({data, ...props}: PDiskPopupProps) => { | |||
| const nodeHost = valueIsDefined(data.NodeId) ? nodeHostsMap?.get(data.NodeId) : undefined; | |||
| const info = React.useMemo(() => preparePDiskData(data, nodeHost), [data, nodeHost]); | |||
|
|
|||
| const [isPopupOpen, setIsPopupOpen] = React.useState(props.open); | |||
There was a problem hiding this comment.
let's not stick to props value as initial. Let it be separate property lets say [isPopupHovered, setIsPopupHovered] = React.useState(false)
| @@ -136,6 +136,13 @@ interface VDiskPopupProps extends PopupProps { | |||
|
|
|||
| export const VDiskPopup = ({data, ...props}: VDiskPopupProps) => { | |||
| const isFullData = isFullVDiskData(data); | |||
| const [isPopupOpen, setIsPopupOpen] = React.useState(props.open); | |||
Raubzeug
approved these changes
Oct 11, 2024
astandrik
deleted the
astandrik.do-not-hide-pdisk-and-vdisk-popups-1360
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1360
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: ✅
Current: 78.97 MB | Main: 78.97 MB
Diff: +0.00 MB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information