Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Cluster): rework cluster page #1473

Merged
merged 4 commits into from
Oct 21, 2024
Merged

feat(Cluster): rework cluster page #1473

merged 4 commits into from
Oct 21, 2024

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Oct 16, 2024 •
edited by github-actions bot
Loading

closes #1389
stand

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
134 134 0 0 0

Bundle Size: 🔺

Current: 79.02 MB | Main: 78.97 MB
Diff: +0.05 MB (0.06%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@Raubzeug Raubzeug mentioned this pull request Oct 16, 2024
Merged
astandrik
astandrik reviewed Oct 17, 2024
View reviewed changes
src/utils/numeral.ts Outdated Show resolved Hide resolved
astandrik
astandrik reviewed Oct 21, 2024
View reviewed changes
src/utils/utils.ts Outdated
@@ -104,3 +104,5 @@ export function isNumeric(value?: unknown): value is number | string {
export function toExponential(value: number, precision?: number) {
return Number(value).toExponential(precision);
}

export const unbreakableGap = '\xa0';
Copy link
Contributor

@astandrik astandrik Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global constants are usually named in SCREAMING_SNAKE_CASE

astandrik
astandrik previously approved these changes Oct 21, 2024
View reviewed changes
@astandrik astandrik self-requested a review October 21, 2024 10:13
@Raubzeug Raubzeug added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit ee06b4e Oct 21, 2024
6 checks passed
@Raubzeug Raubzeug deleted the 1389-cluster-overview branch October 21, 2024 10:27
@ydb-platform-bot ydb-platform-bot mentioned this pull request Oct 18, 2024
Merged
@artemmufazalov artemmufazalov mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astandrik astandrik astandrik approved these changes

@artemmufazalov artemmufazalov Awaiting requested review from artemmufazalov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cluster overview - development issue
2 participants
@Raubzeug @astandrik