feat(SchemaTree): add actions for topic #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested changes
Aug 14, 2023
Comment on lines
69
to
70
| retention_storage_mb = 1, -- Limit on the maximum disk space occupied by the topic data. When this value is exceeded, | ||
| -- the older data is cleared, like under a retention policy. 0 is interpreted as unlimited. |
There was a problem hiding this comment.
It's better to split by sentences. So -- When this value is exceeded, the older data is ...
Comment on lines
89
to
90
| retention_storage_mb = 10, -- Limit on the maximum disk space occupied by the topic data. When this value is exceeded, | ||
| -- the older data is cleared, like under a retention policy. 0 is interpreted as unlimited. |
There was a problem hiding this comment.
It's better to split by sentences
-- When this value is exceeded, the older data is cleared, like under a retention policy.
-- 0 is interpreted as unlimited.
artemmufazalov
approved these changes
Aug 15, 2023
krosy1337
force-pushed
the
add-create-topic
branch
from
72ca071
to
fddf86a
Compare
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.