fix(AsyncReplication): fix table styles #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Jun 10, 2024
Comment on lines
+124
to
+131
| // DataTable with moving head is actually made of two separate tables | ||
| // The second table has header with zero height, so it's actually invisible | ||
| // There should not be any height set for this header | ||
| .data-table__box_sticky-head_moving { | ||
| .data-table__th { | ||
| height: unset; | ||
| } | ||
| } |
There was a problem hiding this comment.
Previously styles above were applied only to DataTable with moving head. Now styles apply to all tables: tables with stickyHead moving and fixed, common tables (stickyHead = undefined). moving head exception was explicitly defined with comment
Raubzeug
approved these changes
Jun 10, 2024
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #886
Test stand: https://nda.ya.ru/t/yQN0U4t776LxxG