Make coordination session ping period dependent on session timeout KI… (

#1837)
ydb-platform · Feb 13, 2024 · e95a49c · e95a49c
1 parent 3db86df
commit e95a49c
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/ydb/services/kesus/grpc_service.cpp b/ydb/services/kesus/grpc_service.cpp
@@ -27,6 +27,9 @@ namespace NKesus {
 class TGRpcSessionActor
     : public TActorBootstrapped<TGRpcSessionActor>
 {
+    static constexpr TDuration MinPingPeriod = TDuration::MilliSeconds(10);
+    static constexpr TDuration MaxPingPeriod = TDuration::Seconds(5);
+
 public:
     using TRequest = Ydb::Coordination::SessionRequest;
     using TResponse = Ydb::Coordination::SessionResponse;
@@ -132,6 +135,13 @@ class TGRpcSessionActor
             return PassAway();
         }
 
+        PingPeriod = TDuration::MilliSeconds(StartRequest->Record.session_start().timeout_millis() / 3);
+        if (PingPeriod > MaxPingPeriod) {
+            PingPeriod = MaxPingPeriod;
+        } else if (PingPeriod < MinPingPeriod) {
+            PingPeriod = MinPingPeriod;
+        }
+
         KesusPath = StartRequest->Record.session_start().path();
 
         auto resolve = MakeHolder<TEvKesusProxy::TEvResolveKesusProxy>(KesusPath);
@@ -540,8 +550,7 @@ class TGRpcSessionActor
         ping->set_opaque(CurrentPingData);
         Reply(std::move(response));
 
-        // TODO: configure timeout
-        Schedule(TDuration::MilliSeconds(5000), new TEvPrivate::TEvPingScheduled());
+        Schedule(PingPeriod, new TEvPrivate::TEvPingScheduled());
     }
 
     void Handle(const TEvPrivate::TEvPingScheduled::TPtr& ev) {
@@ -599,6 +608,7 @@ class TGRpcSessionActor
     ui64 SessionId = 0;
     bool SessionEstablished = false;
     ui64 CurrentPingData = 0;
+    TDuration PingPeriod;
 };
 
 ////////////////////////////////////////////////////////////////////////////////