Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamlookup: fix zero default for MaxDelayedRows #10735

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Oct 22, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@yumkam yumkam marked this pull request as ready for review October 22, 2024 17:05
@yumkam yumkam requested a review from a team as a code owner October 22, 2024 17:05
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 17:06:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2e4c14f has started.
2024-10-22 17:07:01 UTC Artifacts will be uploaded here
2024-10-22 17:07:29 UTC Check cancelled

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 17:06:38 UTC Pre-commit check linux-x86_64-release-asan for 2e4c14f has started.
2024-10-22 17:07:19 UTC Check cancelled

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 17:10:44 UTC Pre-commit check linux-x86_64-release-asan for 7742e42 has started.
2024-10-22 17:10:54 UTC Artifacts will be uploaded here
2024-10-22 17:13:56 UTC ya make is running...
🟡 2024-10-22 18:44:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10673 10470 0 41 58 104

🟢 2024-10-22 18:45:17 UTC Build successful.
🟢 2024-10-22 18:45:51 UTC ydbd size 5.7 GiB changed* by +71.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7a1e697 merge: 7742e42 diff diff %
ydbd size 6 099 697 000 Bytes 6 099 770 008 Bytes +71.3 KiB +0.001%
ydbd stripped size 1 522 515 568 Bytes 1 522 524 720 Bytes +8.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 17:12:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7742e42 has started.
2024-10-22 17:13:07 UTC Artifacts will be uploaded here
2024-10-22 17:16:17 UTC ya make is running...
🟡 2024-10-22 18:29:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73689 59686 0 2 13904 97

2024-10-22 18:36:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-22 18:48:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 4 0 0 0 94

🟢 2024-10-22 18:48:16 UTC Build successful.
🟢 2024-10-22 18:48:38 UTC ydbd size 2.8 GiB changed* by +224 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4d1ccf4 merge: 7742e42 diff diff %
ydbd size 3 012 367 520 Bytes 3 012 367 744 Bytes +224 Bytes +0.000%
ydbd stripped size 478 202 168 Bytes 478 202 168 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam requested a review from rvu1024 October 23, 2024 11:39
@yumkam yumkam merged commit cf5cb23 into ydb-platform:main Oct 23, 2024
10 checks passed
yumkam added a commit to yumkam/ydb that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants