Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resharding, add logging to writer #10864

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Oct 24, 2024

Changelog entry

Fixed a bug where restoring from a backup using --import-data could fail if the partitioning of the table was changed.

Changelog category

  • Bugfix

Additional information

...

@CyberROFL CyberROFL self-assigned this Oct 24, 2024
@CyberROFL CyberROFL requested a review from pixcc October 24, 2024 18:06
@CyberROFL CyberROFL marked this pull request as ready for review October 24, 2024 18:09
Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 18:11:28 UTC Pre-commit check linux-x86_64-release-asan for 8061cee has started.
2024-10-24 18:11:40 UTC Artifacts will be uploaded here
2024-10-24 18:14:08 UTC ya make is running...
🟢 2024-10-24 18:22:12 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
722 720 0 0 2 0

🟢 2024-10-24 18:22:21 UTC Build successful.
🟢 2024-10-24 18:22:35 UTC ydbd size 5.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8a06f46 merge: 8061cee diff diff %
ydbd size 6 139 138 472 Bytes 6 139 138 376 Bytes -96 Bytes -0.000%
ydbd stripped size 1 532 446 640 Bytes 1 532 446 576 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 18:11:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8061cee has started.
2024-10-24 18:11:41 UTC Artifacts will be uploaded here
2024-10-24 18:14:18 UTC ya make is running...
🟢 2024-10-24 18:20:40 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
745 743 0 0 2 0

🟢 2024-10-24 18:20:49 UTC Build successful.
🟢 2024-10-24 18:20:59 UTC ydbd size 2.8 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8a06f46 merge: 8061cee diff diff %
ydbd size 3 033 910 736 Bytes 3 033 910 736 Bytes 0 Bytes 0.000%
ydbd stripped size 481 130 872 Bytes 481 130 872 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL enabled auto-merge (squash) October 24, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant