Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQL-17706 fixed deallocation size #1449

Merged
merged 2 commits into from
Jan 31, 2024
Merged

YQL-17706 fixed deallocation size #1449

merged 2 commits into from
Jan 31, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Jan 31, 2024 •
edited
Loading

No description provided.

@vitstn vitstn requested a review from a team as a code owner January 31, 2024 08:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

⚪ 2024-01-31 08:31:28 UTC Pre-commit check for fcf9fae has started.
⚪ 2024-01-31 08:31:29 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-31 08:34:07 UTC Build successful.
⚪ 2024-01-31 08:34:16 UTC Tests are running...
🔴 2024-01-31 08:48:12 UTC Test run completed, no test results found for commit b8a15b5. Please check build logs.
⚫ 2024-01-31 08:48:16 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

⚪ 2024-01-31 08:32:02 UTC Pre-commit check for fcf9fae has started.
⚪ 2024-01-31 08:32:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-31 08:34:10 UTC Build successful.
⚪ 2024-01-31 08:34:22 UTC Tests are running...
🔴 2024-01-31 08:48:12 UTC Test run completed, no test results found for commit b8a15b5. Please check build logs.
⚫ 2024-01-31 08:48:16 UTC Check cancelled

marsaly79
marsaly79 reviewed Jan 31, 2024
View reviewed changes
ydb/library/yql/minikql/mkql_alloc.cpp
@@ -37,7 +37,8 @@ void TAllocState::CleanupPAllocList(TListEntry* root) {
for (auto curr = root->Right; curr != root; ) {
auto next = curr->Right;
auto size = ((TMkqlPAllocHeader*)curr)->Size;
MKQLFreeWithSize(curr, size, EMemorySubPool::Default); // may free items from OffloadedBlocksRoot
auto fullSize = size + sizeof(TMkqlPAllocHeader);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

⚪ 2024-01-31 08:49:41 UTC Pre-commit check for c0d4aec has started.
⚪ 2024-01-31 08:49:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-31 08:52:46 UTC Build successful.
⚪ 2024-01-31 08:52:57 UTC Tests are running...
🔴 2024-01-31 10:28:06 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60343 51034 0 3 9270 36

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

⚪ 2024-01-31 08:51:41 UTC Pre-commit check for c0d4aec has started.
⚪ 2024-01-31 08:51:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-31 08:54:13 UTC Build successful.
⚪ 2024-01-31 08:54:33 UTC Tests are running...
🔴 2024-01-31 10:32:06 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16019 15901 0 24 57 37

@vitstn vitstn merged commit 264201f into ydb-platform:main Jan 31, 2024
2 of 4 checks passed
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
This was referenced Jan 31, 2024
Closed
Merged
This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 3, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 4, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Closed
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsaly79 marsaly79 marsaly79 left review comments

@nepal nepal nepal approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitstn @nepal @marsaly79