Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic listing mass fix #1913

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Dynamic listing mass fix #1913

merged 7 commits into from
Feb 26, 2024

Conversation

Hor911
Copy link
Collaborator

@Hor911 Hor911 commented Feb 14, 2024

  • Bugfix

@Hor911 Hor911 requested review from a team as code owners February 14, 2024 10:33
Copy link

github-actions bot commented Feb 14, 2024

2024-02-14 10:36:40 UTC Pre-commit check for f0ce60b has started.
2024-02-14 10:36:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-14 10:42:57 UTC Build successful.
2024-02-14 10:43:11 UTC Tests are running...
🔴 2024-02-14 10:45:35 UTC Test run completed, no test results found for commit b50b536. Please check build logs.
2024-02-14 10:45:37 UTC Check cancelled

Copy link

github-actions bot commented Feb 14, 2024

2024-02-14 10:36:45 UTC Pre-commit check for f0ce60b has started.
2024-02-14 10:36:46 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-14 10:44:39 UTC Build successful.
2024-02-14 10:44:51 UTC Tests are running...
🔴 2024-02-14 10:45:33 UTC Test run completed, no test results found for commit b50b536. Please check build logs.
2024-02-14 10:45:35 UTC Check cancelled

Copy link

github-actions bot commented Feb 14, 2024

2024-02-14 10:46:42 UTC Pre-commit check for b572e6e has started.
2024-02-14 10:46:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-14 10:48:32 UTC Build successful.
2024-02-14 10:48:39 UTC Tests are running...
🔴 2024-02-14 11:22:23 UTC Test run completed, no test results found for commit f9eefae. Please check build logs.
2024-02-14 11:22:25 UTC Check cancelled

Copy link

github-actions bot commented Feb 14, 2024

2024-02-14 10:54:18 UTC Pre-commit check for b572e6e has started.
2024-02-14 10:54:19 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-14 10:56:51 UTC Build successful.
2024-02-14 10:57:00 UTC Tests are running...
🔴 2024-02-14 11:22:29 UTC Test run completed, no test results found for commit f9eefae. Please check build logs.
2024-02-14 11:22:33 UTC Check cancelled

Copy link

github-actions bot commented Feb 14, 2024

2024-02-14 11:46:26 UTC Pre-commit check for 358f058 has started.
2024-02-14 11:46:27 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-14 11:50:59 UTC Build successful.
2024-02-14 11:51:08 UTC Tests are running...
🔴 2024-02-14 13:32:37 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67396 56441 0 17 10901 37

Copy link

github-actions bot commented Feb 14, 2024

2024-02-14 11:46:59 UTC Pre-commit check for 358f058 has started.
2024-02-14 11:47:01 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-14 11:52:49 UTC Build successful.
2024-02-14 11:52:59 UTC Tests are running...
🔴 2024-02-14 13:31:18 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14766 14635 0 20 74 37

Copy link

github-actions bot commented Feb 19, 2024

2024-02-19 11:23:44 UTC Pre-commit check for 5905039 has started.
2024-02-19 11:23:45 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-19 11:31:30 UTC Build successful.
2024-02-19 11:31:40 UTC Tests are running...
🔴 2024-02-19 13:17:45 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14775 14633 0 23 93 26

Copy link

github-actions bot commented Feb 19, 2024

2024-02-19 11:24:20 UTC Pre-commit check for 5905039 has started.
2024-02-19 11:24:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-19 11:31:12 UTC Build successful.
2024-02-19 11:31:25 UTC Tests are running...
🔴 2024-02-19 13:23:36 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67570 56571 0 9 10924 66

hFunc(TEvPrivate::TEvReadStarted, Handle);
hFunc(TEvPrivate::TEvDataPart, Handle);
hFunc(TEvPrivate::TEvReadFinished, Handle);
hFunc(TEvPrivate::TEvContinue, Handle);
hFunc(TEvPrivate::TEvReadResult2, Handle);
hFunc(NActors::TEvents::TEvPoison, Handle);
, catch (const std::exception& e) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

что за страшный синтаксис? нельзя обернуть свитч в try/catch ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Так делают, но красивше не становится. Потому что весь сложный заголовок StateFunc вылезает из под макроса и еще по мелочи

Copy link

github-actions bot commented Feb 21, 2024

2024-02-21 09:43:45 UTC Pre-commit check for 69932d8 has started.
2024-02-21 09:43:47 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-02-21 09:51:25 UTC Build failed. see the build logs.
2024-02-21 09:51:42 UTC Tests are running...
🔴 2024-02-21 10:15:53 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
36680 28778 0 294 7596 12

Copy link

github-actions bot commented Feb 21, 2024

2024-02-21 09:46:16 UTC Pre-commit check for 69932d8 has started.
2024-02-21 09:46:19 UTC Build linux-x86_64-release-asan is running...
🔴 2024-02-21 09:53:15 UTC Build failed. see the build logs.
2024-02-21 09:53:27 UTC Tests are running...
🔴 2024-02-21 10:03:49 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6079 5809 0 258 2 10

Copy link

github-actions bot commented Feb 21, 2024

2024-02-21 14:39:22 UTC Pre-commit check for 0674201 has started.
2024-02-21 14:39:24 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-21 14:44:45 UTC Build successful.
2024-02-21 14:44:55 UTC Tests are running...
🔴 2024-02-21 16:23:24 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14820 14673 0 24 96 27

Copy link

github-actions bot commented Feb 21, 2024

2024-02-21 14:39:39 UTC Pre-commit check for 0674201 has started.
2024-02-21 14:39:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-21 14:44:40 UTC Build successful.
2024-02-21 14:44:54 UTC Tests are running...
🔴 2024-02-21 16:34:38 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67800 56890 0 3 10883 24

@Hor911 Hor911 merged commit 35f59b7 into ydb-platform:main Feb 26, 2024
2 of 4 checks passed
Hor911 added a commit to Hor911/ydb that referenced this pull request Mar 3, 2024
@shnikd shnikd mentioned this pull request Mar 26, 2024
EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 5, 2024
EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants