Refactoring of pqconfig.proto - extract message Consumer instead of separeted arrays of ReadRules #2347

nshestakov · 2024-02-29T13:51:00Z

Changelog entry

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

...

github-actions · 2024-02-29T13:54:06Z

⚪ 2024-02-29 13:54:06 UTC Pre-commit check for 1cdc217 has started.
⚪ 2024-02-29 13:54:11 UTC Build linux-x86_64-release-cmake14 is running...
⚫ 2024-02-29 14:18:31 UTC Check cancelled

github-actions · 2024-02-29T13:54:12Z

⚪ 2024-02-29 13:54:12 UTC Pre-commit check for 1cdc217 has started.
⚪ 2024-02-29 13:54:14 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-02-29 14:18:29 UTC Check cancelled

github-actions · 2024-02-29T13:54:12Z

⚪ 2024-02-29 13:54:12 UTC Pre-commit check for 1cdc217 has started.
⚪ 2024-02-29 13:54:14 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-02-29 14:18:30 UTC Check cancelled

github-actions · 2024-02-29T14:20:01Z

⚪ 2024-02-29 14:20:00 UTC Pre-commit check for 4f922a0 has started.
⚪ 2024-02-29 14:20:03 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-29 14:29:01 UTC Build successful.

github-actions · 2024-02-29T14:20:19Z

⚪ 2024-02-29 14:20:19 UTC Pre-commit check for 4f922a0 has started.
⚪ 2024-02-29 14:20:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-29 14:34:12 UTC Build successful.
⚪ 2024-02-29 14:34:25 UTC Tests are running...
🔴 2024-02-29 15:08:31 UTC Test run completed, no test results found for commit 01a27bb. Please check build logs.
⚫ 2024-02-29 15:08:35 UTC Check cancelled

github-actions · 2024-02-29T14:20:31Z

⚪ 2024-02-29 14:20:31 UTC Pre-commit check for 4f922a0 has started.
⚪ 2024-02-29 14:20:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-29 14:32:06 UTC Build successful.
⚪ 2024-02-29 14:32:22 UTC Tests are running...
🔴 2024-02-29 15:08:32 UTC Test run completed, no test results found for commit 01a27bb. Please check build logs.
⚫ 2024-02-29 15:08:36 UTC Check cancelled

alexnick88 · 2024-02-29T14:28:27Z

ydb/core/persqueue/partition.cpp

@@ -1897,8 +1896,6 @@ void TPartition::EndChangePartitionConfig(const NKikimrPQ::TPQTabletConfig& conf

    Y_ABORT_UNLESS(Config.GetPartitionConfig().GetTotalPartitions() > 0);

-    UsersInfoStorage->UpdateConfig(Config);


May be this is a bug. Where is config in UsersInfoStorage updated?

used reference now

ydb/core/protos/pqconfig.proto

alexnick88 · 2024-02-29T14:33:36Z

ydb/services/lib/actors/pq_schema_actor.cpp

+                    continue;
+                }
+
+                config->AddReadRuleVersions(originalConfig.GetReadRuleVersions(i));


Why do not to convert config to new version before processing?

github-actions · 2024-02-29T15:10:21Z

⚪ 2024-02-29 15:10:21 UTC Pre-commit check for e65f6f4 has started.
⚪ 2024-02-29 15:10:23 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-02-29 15:44:22 UTC Build failed. see the build logs.
⚪ 2024-02-29 15:44:35 UTC Tests are running...
🔴 2024-02-29 16:15:30 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
58818	47670	0	269	10867	12

github-actions · 2024-02-29T15:10:39Z

⚪ 2024-02-29 15:10:39 UTC Pre-commit check for e65f6f4 has started.
⚪ 2024-02-29 15:10:41 UTC Build linux-x86_64-release-asan is running...
🔴 2024-02-29 15:47:39 UTC Build failed. see the build logs.
⚪ 2024-02-29 15:47:53 UTC Tests are running...
🔴 2024-02-29 16:02:35 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
6063	5777	0	267	9	10

github-actions · 2024-02-29T15:11:32Z

⚪ 2024-02-29 15:11:32 UTC Pre-commit check for e65f6f4 has started.
⚪ 2024-02-29 15:11:34 UTC Build linux-x86_64-release-cmake14 is running...
🔴 2024-02-29 15:42:51 UTC Build failed. see the build logs.

github-actions · 2024-03-01T06:12:19Z

⚪ 2024-03-01 06:12:19 UTC Pre-commit check for 5da27cd has started.
⚪ 2024-03-01 06:12:21 UTC Build linux-x86_64-release-cmake14 is running...
⚫ 2024-03-01 06:24:08 UTC Check cancelled

github-actions · 2024-03-01T06:12:20Z

⚪ 2024-03-01 06:12:19 UTC Pre-commit check for 5da27cd has started.
⚪ 2024-03-01 06:12:22 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-03-01 06:24:07 UTC Check cancelled

github-actions · 2024-03-01T06:14:25Z

⚪ 2024-03-01 06:14:25 UTC Pre-commit check for 5da27cd has started.
⚪ 2024-03-01 06:14:27 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-03-01 06:24:09 UTC Check cancelled

github-actions · 2024-03-01T06:25:13Z

⚪ 2024-03-01 06:25:13 UTC Pre-commit check for 9d84c6b has started.
⚪ 2024-03-01 06:25:15 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-03-01 06:26:12 UTC Check cancelled

github-actions · 2024-03-01T06:25:14Z

⚪ 2024-03-01 06:25:14 UTC Pre-commit check for 9d84c6b has started.
⚪ 2024-03-01 06:25:15 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-03-01 06:26:12 UTC Check cancelled

github-actions · 2024-03-01T15:32:48Z

⚪ 2024-03-01 15:32:48 UTC Pre-commit check for 745142c has started.
⚪ 2024-03-01 15:32:51 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-01 16:06:22 UTC Build successful.

github-actions · 2024-03-01T15:38:42Z

⚪ 2024-03-01 15:38:42 UTC Pre-commit check for 745142c has started.
⚪ 2024-03-01 15:38:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-01 16:12:15 UTC Build successful.
⚪ 2024-03-01 16:12:24 UTC Tests are running...
🔴 2024-03-01 17:42:10 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67978	57051	0	9	10899	19

github-actions · 2024-03-01T15:38:52Z

⚪ 2024-03-01 15:38:52 UTC Pre-commit check for 745142c has started.
⚪ 2024-03-01 15:38:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-01 16:17:39 UTC Build successful.
⚪ 2024-03-01 16:17:51 UTC Tests are running...
🔴 2024-03-01 17:54:59 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14891	14771	0	24	74	22

github-actions · 2024-03-04T05:45:00Z

⚪ 2024-03-04 05:44:59 UTC Pre-commit check for df113a0 has started.
⚪ 2024-03-04 05:45:02 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-04 06:19:03 UTC Build successful.
⚪ 2024-03-04 06:19:17 UTC Tests are running...
🔴 2024-03-04 07:52:54 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68084	57148	0	9	10902	25

github-actions · 2024-03-04T05:45:01Z

⚪ 2024-03-04 05:45:01 UTC Pre-commit check for df113a0 has started.
⚪ 2024-03-04 05:45:04 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-04 06:18:06 UTC Build successful.

github-actions · 2024-03-04T05:45:07Z

⚪ 2024-03-04 05:45:07 UTC Pre-commit check for df113a0 has started.
⚪ 2024-03-04 05:45:09 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-04 06:20:47 UTC Build successful.
⚪ 2024-03-04 06:21:00 UTC Tests are running...
🔴 2024-03-04 08:06:12 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14898	14737	0	32	100	29

nshestakov added 10 commits February 27, 2024 08:40

intermediate refactoring

4a3f12b

intermediate

c2f10dc

fix tests

0e01aec

intermediate

53531ac

if for code for remove

2263e6f

more replaces

2ca71d6

more replaces

031e8a8

more replaces

0ef0d84

more replaces

cbab5d3

fix include

0257895

github-actions bot added the not-for-changelog label Feb 29, 2024

fix

01a27bb

alexnick88 reviewed Feb 29, 2024

View reviewed changes

replace ImportantClientIds

b5badc1

compilation fix

33a6c2d

compilation fix

17d4c6b

fix

ca3e8bc

Merge branch 'main' into refactorPqConfig

f884102

alexnick88 approved these changes Mar 4, 2024

View reviewed changes

nshestakov merged commit a3397fb into ydb-platform:main Mar 4, 2024
3 of 5 checks passed

nshestakov deleted the refactorPqConfig branch March 4, 2024 08:44

StekPerepolnen mentioned this pull request Mar 5, 2024

YDB-647 add media type field #2441

Merged

niksaveliev mentioned this pull request Mar 5, 2024

Revert of revert pq ut couners fix #2449

Merged

GrigoriyPA mentioned this pull request Mar 7, 2024

YQ-2737 add TOKEN auth for YT datasource #2561

Merged

This was referenced Mar 8, 2024

HC made storage issue RED when no bsc reply #2578

Merged

time difference lines2 #2599

Closed

This was referenced Mar 11, 2024

Mute TImportTests.CancelUponCreatingTableShouldSucceed #2609

Merged

Fix TImportTests.CancelUponCreatingTableShouldSucceed #2636

Merged

This was referenced Mar 13, 2024

YQ-2957 fix error in s3 stream read actor #2702

Merged

Fixed error due to empty token #2966

Merged

This was referenced Mar 20, 2024

Test alter temp table #3011

Merged

Support sequences backup with current value #3023

Closed

Support sequences backup with current value #3089

Merged

YDBDOCS-632: Documentation of temporary tables #3137

Merged

GrigoriyPA mentioned this pull request Mar 26, 2024

YQ-2738 add integration tests for YT in KQP #3150

Merged

shnikd mentioned this pull request Mar 26, 2024

Test temp indexes #3163

Merged

shnikd mentioned this pull request Apr 4, 2024

Support create sequence in pg parser #3465

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactoring of pqconfig.proto - extract message Consumer instead of separeted arrays of ReadRules #2347

Refactoring of pqconfig.proto - extract message Consumer instead of separeted arrays of ReadRules #2347

nshestakov commented Feb 29, 2024

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

alexnick88 Feb 29, 2024

nshestakov Feb 29, 2024

alexnick88 Feb 29, 2024

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 4, 2024 •

edited

Loading

github-actions bot commented Mar 4, 2024 •

edited

Loading

github-actions bot commented Mar 4, 2024 •

edited

Loading

		@@ -1897,8 +1896,6 @@ void TPartition::EndChangePartitionConfig(const NKikimrPQ::TPQTabletConfig& conf

		Y_ABORT_UNLESS(Config.GetPartitionConfig().GetTotalPartitions() > 0);

		UsersInfoStorage->UpdateConfig(Config);

Refactoring of pqconfig.proto - extract message Consumer instead of separeted arrays of ReadRules #2347

Refactoring of pqconfig.proto - extract message Consumer instead of separeted arrays of ReadRules #2347

Conversation

nshestakov commented Feb 29, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Feb 29, 2024 • edited Loading

github-actions bot commented Feb 29, 2024 • edited Loading

github-actions bot commented Feb 29, 2024 • edited Loading

github-actions bot commented Feb 29, 2024 • edited Loading

github-actions bot commented Feb 29, 2024 • edited Loading

github-actions bot commented Feb 29, 2024 • edited Loading

alexnick88 Feb 29, 2024

Choose a reason for hiding this comment

nshestakov Feb 29, 2024

Choose a reason for hiding this comment

alexnick88 Feb 29, 2024

Choose a reason for hiding this comment

github-actions bot commented Feb 29, 2024 • edited Loading

github-actions bot commented Feb 29, 2024 • edited Loading

github-actions bot commented Feb 29, 2024 • edited Loading

github-actions bot commented Mar 1, 2024 • edited Loading

github-actions bot commented Mar 1, 2024 • edited Loading

github-actions bot commented Mar 1, 2024 • edited Loading

github-actions bot commented Mar 1, 2024 • edited Loading

github-actions bot commented Mar 1, 2024 • edited Loading

github-actions bot commented Mar 1, 2024 • edited Loading

github-actions bot commented Mar 1, 2024 • edited Loading

github-actions bot commented Mar 1, 2024 • edited Loading

github-actions bot commented Mar 4, 2024 • edited Loading

github-actions bot commented Mar 4, 2024 • edited Loading

github-actions bot commented Mar 4, 2024 • edited Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 4, 2024 •

edited

Loading

github-actions bot commented Mar 4, 2024 •

edited

Loading

github-actions bot commented Mar 4, 2024 •

edited

Loading