Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of nulls first/last #2365

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Support of nulls first/last #2365

merged 3 commits into from
Mar 1, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Feb 29, 2024

Changelog entry

...

Changelog category

  • New feature

Additional information

...

@vitstn vitstn requested a review from a team as a code owner February 29, 2024 21:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited
Loading

⚪ 2024-02-29 21:53:31 UTC Pre-commit check for 829fba7 has started.
⚪ 2024-02-29 21:53:34 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-29 21:59:39 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited
Loading

⚪ 2024-02-29 21:53:32 UTC Pre-commit check for 829fba7 has started.
⚪ 2024-02-29 21:53:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-29 22:00:20 UTC Build successful.
⚪ 2024-02-29 22:00:32 UTC Tests are running...
🔴 2024-02-29 23:43:46 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14889 14763 0 22 81 23

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited
Loading

⚪ 2024-02-29 21:53:37 UTC Pre-commit check for 829fba7 has started.
⚪ 2024-02-29 21:53:39 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-29 22:00:06 UTC Build successful.
⚪ 2024-02-29 22:00:21 UTC Tests are running...
🔴 2024-02-29 23:48:35 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68076 56989 0 170 10899 18

resetius
resetius reviewed Mar 1, 2024
View reviewed changes
ydb/library/yql/sql/pg/pg_sql.cpp
AddError(TStringBuilder() << "sortby_nulls unsupported value: " << (int)value->sortby_nulls);
switch (value->sortby_nulls) {
case SORTBY_NULLS_DEFAULT:
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to preserve Postgres default behaviour here? "NULLS FIRST is the default for DESC order, and NULLS LAST otherwise."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. It's a breaking change

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 09:28:02 UTC Pre-commit check for d017b54 has started.
⚪ 2024-03-01 09:28:05 UTC Build linux-x86_64-release-cmake14 is running...
⚫ 2024-03-01 09:43:04 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 09:28:04 UTC Pre-commit check for d017b54 has started.
⚪ 2024-03-01 09:28:06 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-03-01 09:43:05 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 09:28:21 UTC Pre-commit check for d017b54 has started.
⚪ 2024-03-01 09:28:24 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-03-01 09:43:04 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 09:44:12 UTC Pre-commit check for 4f5ab2c has started.
⚪ 2024-03-01 09:44:14 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-01 09:50:12 UTC Build successful.
⚪ 2024-03-01 09:50:23 UTC Tests are running...
🔴 2024-03-01 11:16:54 UTC Test run completed, no test results found for commit ae582c5. Please check build logs.
⚫ 2024-03-01 11:16:57 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 09:44:33 UTC Pre-commit check for 4f5ab2c has started.
⚪ 2024-03-01 09:44:34 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-01 09:55:00 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 09:46:13 UTC Pre-commit check for 4f5ab2c has started.
⚪ 2024-03-01 09:46:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-01 09:52:52 UTC Build successful.
⚪ 2024-03-01 09:53:05 UTC Tests are running...
🔴 2024-03-01 11:16:54 UTC Test run completed, no test results found for commit ae582c5. Please check build logs.
⚫ 2024-03-01 11:16:58 UTC Check cancelled

@vitstn vitstn added the area/pg label Mar 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 11:18:21 UTC Pre-commit check for 4f5ab2c has started.
⚪ 2024-03-01 11:18:24 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-01 11:19:29 UTC Build successful.
⚪ 2024-03-01 11:19:43 UTC Tests are running...
🔴 2024-03-01 11:41:01 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14892 14762 0 26 81 23

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 11:19:54 UTC Pre-commit check for 4f5ab2c has started.
⚪ 2024-03-01 11:19:56 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-01 11:21:00 UTC Build successful.
⚪ 2024-03-01 11:21:12 UTC Tests are running...
🔴 2024-03-01 11:47:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67976 57050 0 7 10899 20

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 11:20:40 UTC Pre-commit check for 4f5ab2c has started.
⚪ 2024-03-01 11:20:42 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-01 11:21:44 UTC Build successful.

@vitstn vitstn merged commit d4a0c62 into ydb-platform:main Mar 1, 2024
5 of 9 checks passed
@StekPerepolnen StekPerepolnen mentioned this pull request Mar 5, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Mar 5, 2024
Merged
This was referenced Mar 6, 2024
Merged
Open
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 7, 2024
Merged
This was referenced Mar 8, 2024
Merged
Closed
@shnikd shnikd mentioned this pull request Mar 11, 2024
Merged
@shnikd shnikd mentioned this pull request Mar 11, 2024
Merged
This was referenced Mar 13, 2024
Merged
Merged
This was referenced Mar 20, 2024
Merged
Closed
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resetius resetius resetius approved these changes

Assignees
No one assigned
Labels
area/pg new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitstn @resetius