-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of nulls first/last #2365
Conversation
⚪
|
⚪
|
AddError(TStringBuilder() << "sortby_nulls unsupported value: " << (int)value->sortby_nulls); | ||
switch (value->sortby_nulls) { | ||
case SORTBY_NULLS_DEFAULT: | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to preserve Postgres default behaviour here? "NULLS FIRST is the default for DESC order, and NULLS LAST otherwise."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. It's a breaking change
⚪ |
⚪ |
⚪
|
⚪
|
Changelog entry
...
Changelog category
Additional information
...