Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-1: Fix followers not reading system tables and not processing requests #4343

Merged

Conversation

snaury
Copy link
Member

@snaury snaury commented May 7, 2024

Changelog entry

Fix followers not reading system tables and not processing requests

Changelog category

  • Bugfix

Additional information

Followers cache change counters for system tables, so as not to re-read them before every request. Unfortunately, the change counter may be zero when follower boots immediately after a system table is compacted, and until more changes are written. This caused them to sometimes reject all read requests due to mismatching table identifiers.

Fixes #4275.
Fixes KIKIMR-21133.
Merges #4314.

Copy link

github-actions bot commented May 7, 2024

2024-05-07 08:42:57 UTC Pre-commit check for 5b3208b has started.
2024-05-07 08:43:00 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-07 09:10:57 UTC Build successful.
2024-05-07 09:11:12 UTC Tests are running...
🔴 2024-05-07 10:45:48 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16072 15991 0 12 42 27

Copy link

github-actions bot commented May 7, 2024

2024-05-07 08:43:07 UTC Pre-commit check for 5b3208b has started.
2024-05-07 08:43:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-07 09:22:52 UTC Build successful.
2024-05-07 09:23:06 UTC Tests are running...
🟢 2024-05-07 10:47:42 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60409 51010 0 0 9342 57

@snaury snaury self-assigned this May 7, 2024
@snaury snaury marked this pull request as ready for review May 7, 2024 11:05
@snaury snaury requested a review from a team as a code owner May 7, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants