Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed build error in TForgetScriptExecutionOperationQueryActor #5084

Merged
merged 1 commit into from
May 31, 2024
Merged

Fixed build error in TForgetScriptExecutionOperationQueryActor #5084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ydb/core/kqp/proxy_service/kqp_script_executions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@ class TCheckLeaseStatusActor : public TCheckLeaseStatusActorBase {
};

class TForgetScriptExecutionOperationQueryActor : public TQueryBase {
static constexpr i64 MAX_NUMBER_ROWS_IN_BATCH = 100000;
static constexpr i32 MAX_NUMBER_ROWS_IN_BATCH = 100000;

public:
TForgetScriptExecutionOperationQueryActor(const TString& executionId, const TString& database, TInstant operationDeadline)
Expand Down Expand Up @@ -877,12 +877,12 @@ class TForgetScriptExecutionOperationQueryActor : public TQueryBase {

result.TryNextRow();

TMaybe<i64> maxResultSetId = result.ColumnParser("max_result_set_id").GetOptionalInt32();
TMaybe<i32> maxResultSetId = result.ColumnParser("max_result_set_id").GetOptionalInt32();
if (!maxResultSetId) {
Finish();
return;
}
NumberRowsInBatch = std::max(MAX_NUMBER_ROWS_IN_BATCH / (*maxResultSetId + 1), 1l);
NumberRowsInBatch = std::max(MAX_NUMBER_ROWS_IN_BATCH / (*maxResultSetId + 1), 1);

TMaybe<i64> maxRowId = result.ColumnParser("max_row_id").GetOptionalInt64();
if (!maxRowId) {
Expand Down
Loading