Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow read table returns and use not null types via public API #5219

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

dcherednik
Copy link
Member

No description provided.

We already have checks for value tuple element count and do not want to change error messages in case of violation.

Changelog category

Bugfix
Support for not null response for ReadTable [1/2 commit]
- We need to support compatibility with old datashard. In this commit if client ask
we send ReadTableTransaction and ask for V2 response format. Old datashard doesn't
know about this format and use legasy response instead. We treat this response as error.



Support for not null response for ReadTable [2/2 commit]
- Datashard support for ReadTable transaction with not null support.

Now datashard can handle new flag and returns proper ResultSet
@dcherednik dcherednik requested a review from a team as a code owner June 5, 2024 11:52
Copy link

github-actions bot commented Jun 5, 2024

2024-06-05 12:29:33 UTC Pre-commit check for 5401d84 has started.
2024-06-05 12:29:35 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-05 13:22:55 UTC Build successful.
2024-06-05 13:23:11 UTC Tests are running...

Copy link

github-actions bot commented Jun 5, 2024

2024-06-05 12:42:49 UTC Pre-commit check for 5401d84 has started.
2024-06-05 12:42:51 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-05 13:37:24 UTC Build successful.
2024-06-05 13:37:36 UTC Tests are running...
🔴 2024-06-05 15:26:38 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16112 16000 0 21 53 38

@dcherednik dcherednik changed the title Allow read table returns and use not null types in API Allow read table returns and use not null types via public API Jul 4, 2024
@dcherednik dcherednik merged commit 7646f2c into ydb-platform:stable-24-1 Jul 4, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants