Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PG-syntax mixed-types joins #5556

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Fix PG-syntax mixed-types joins #5556

merged 3 commits into from
Jun 20, 2024

Conversation

marsaly79
Copy link
Collaborator

Changelog entry

Support joins with non-equal LHS & RHS types in PG-syntax.

Changelog category

  • Bugfix

Additional information

...

@marsaly79 marsaly79 requested a review from a team as a code owner June 14, 2024 11:03
@marsaly79 marsaly79 self-assigned this Jun 14, 2024
@marsaly79 marsaly79 requested a review from vitstn June 14, 2024 11:03
@marsaly79 marsaly79 mentioned this pull request Jun 14, 2024
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 11:06:39 UTC Pre-commit check for 16a2f33 has started.
⚪ 2024-06-14 11:09:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-14 11:12:42 UTC Build successful.
⚪ 2024-06-14 11:12:59 UTC Tests are running...
🔴 2024-06-14 12:55:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10432 10362 0 18 40 12

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 11:09:02 UTC Pre-commit check for 16a2f33 has started.
⚪ 2024-06-14 11:11:24 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-14 11:14:43 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 11:12:57 UTC Pre-commit check for 16a2f33 has started.
⚪ 2024-06-14 11:15:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-14 11:18:42 UTC Build successful.
⚪ 2024-06-14 11:18:58 UTC Tests are running...
🔴 2024-06-14 13:24:46 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70484 57647 0 2 12827 8

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

⚪ 2024-06-20 11:06:09 UTC Pre-commit check for b35176c has started.
⚪ 2024-06-20 11:08:41 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-20 11:12:01 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

⚪ 2024-06-20 11:06:46 UTC Pre-commit check for b35176c has started.
⚪ 2024-06-20 11:09:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-20 11:12:21 UTC Build successful.
⚪ 2024-06-20 11:12:35 UTC Tests are running...
🔴 2024-06-20 13:10:55 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10495 10383 0 31 66 15

🟢 2024-06-20 13:11:33 UTC ydbd size 5.7 GiB changed by -560 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 43d5e45 merge: b35176c diff diff %
ydbd size 6 149 147 040 Bytes 6 149 146 480 Bytes -560 Bytes -0.000%
ydbd stripped size 1 527 438 112 Bytes 1 527 438 048 Bytes -64 Bytes -0.000%

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

⚪ 2024-06-20 11:12:43 UTC Pre-commit check for b35176c has started.
⚪ 2024-06-20 11:15:14 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-20 11:18:27 UTC Build successful.
⚪ 2024-06-20 11:18:40 UTC Tests are running...
🔴 2024-06-20 13:46:01 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71166 57852 0 6 13297 11

🟢 2024-06-20 13:46:42 UTC ydbd size 8.6 GiB changed by -3.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 43d5e45 merge: b35176c diff diff %
ydbd size 9 214 548 552 Bytes 9 214 545 064 Bytes -3.4 KiB -0.000%
ydbd stripped size 711 277 424 Bytes 711 277 232 Bytes -192 Bytes -0.000%

@marsaly79 marsaly79 merged commit d95d5c6 into ydb-platform:main Jun 20, 2024
8 of 12 checks passed
@marsaly79 marsaly79 deleted the fix-pg-join-implicit-casts branch June 20, 2024 14:04
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 20, 2024
Merged
This was referenced Jun 21, 2024
Merged
Merged
marsaly79 added a commit to marsaly79/ydb that referenced this pull request Jun 26, 2024
@marsaly79
Revert "Fix PG-syntax mixed-types joins (ydb-platform#5556)"
b62892b 
This reverts commit d95d5c6.
marsaly79 added a commit that referenced this pull request Jun 26, 2024
@marsaly79
Revert "Fix PG-syntax mixed-types joins (#5556)" (#5947)
23bc78b
@niksaveliev niksaveliev mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitstn vitstn vitstn approved these changes

Assignees

@marsaly79 marsaly79

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marsaly79 @vitstn