[Ticket parser] Print certificate fingerprint in debug message #5650

molotkov-and · 2024-06-17T16:16:43Z

No description provided.

github-actions · 2024-06-17T16:18:52Z

⚪ 2024-06-17 16:18:52 UTC Pre-commit check for be56bc8 has started.
⚪ 2024-06-17 16:21:16 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-17 16:24:26 UTC Build successful.

github-actions · 2024-06-17T16:19:49Z

⚪ 2024-06-17 16:19:49 UTC Pre-commit check for be56bc8 has started.
⚪ 2024-06-17 16:22:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-17 16:25:17 UTC Build successful.
⚪ 2024-06-17 16:25:30 UTC Tests are running...
🔴 2024-06-17 18:02:50 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
37756	32925	0	1	4818	12

github-actions · 2024-06-17T16:32:54Z

⚪ 2024-06-17 16:32:54 UTC Pre-commit check for be56bc8 has started.
⚪ 2024-06-17 16:35:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-17 16:38:07 UTC Build successful.
⚪ 2024-06-17 16:38:16 UTC Tests are running...
🔴 2024-06-17 18:20:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9732	9686	0	15	21	10

github-actions · 2024-06-18T09:27:55Z

⚪ 2024-06-18 09:27:55 UTC Pre-commit check for 3928371 has started.
⚪ 2024-06-18 09:30:23 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-18 09:34:35 UTC Build successful.

github-actions · 2024-06-18T09:28:00Z

⚪ 2024-06-18 09:27:59 UTC Pre-commit check for 3928371 has started.
⚪ 2024-06-18 09:30:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-18 09:33:58 UTC Build successful.
⚪ 2024-06-18 09:34:13 UTC Tests are running...
🔴 2024-06-18 11:16:35 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9731	9691	0	11	20	9

github-actions · 2024-06-18T09:35:42Z

⚪ 2024-06-18 09:35:42 UTC Pre-commit check for 3928371 has started.
⚪ 2024-06-18 09:38:00 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-18 09:41:15 UTC Build successful.
⚪ 2024-06-18 09:41:28 UTC Tests are running...
🟢 2024-06-18 11:25:02 UTC Tests successful.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
37758	32917	0	0	4830	11

github-actions · 2024-06-19T12:33:41Z

⚪ 2024-06-19 12:33:41 UTC Pre-commit check for 22be482 has started.
⚪ 2024-06-19 12:36:04 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-19 12:50:43 UTC Build successful.

adameat · 2024-06-19T12:35:47Z

ydb/core/security/certificate_check/cert_auth_processor.cpp

@@ -98,6 +99,15 @@ TVector<std::pair<TString, TString>> X509CertificateReader::ReadIssuerTerms(cons
    return ReadTerms(name);
 }

+TString X509CertificateReader::GetFingerprint(const X509Ptr& x509) {
+    unsigned char fingerprint[128];


is there any corresponding constant for that?

Yes, I added constant SHA_DIGEST_LENGTH for sha1 digest

github-actions · 2024-06-19T12:49:17Z

⚪ 2024-06-19 12:49:16 UTC Pre-commit check for 22be482 has started.
⚪ 2024-06-19 12:51:39 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-19 12:59:40 UTC Build successful.
⚪ 2024-06-19 12:59:49 UTC Tests are running...
🟢 2024-06-19 14:20:13 UTC Tests successful.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15134	13835	0	0	1285	14

🟡 2024-06-19 14:20:51 UTC merge: 22be482 ydbd size 8.6 GiB +842.8 KiB +0.009% vs build main: ba35e13

Build size details

main: ba35e13 ydbd build size:

binary size 9 211 800 712 Bytes
stripped binary size 711 187 376 Bytes

merge: 22be482 ydbd build size:

binary size 9 212 663 752 Bytes
stripped binary size 711 238 192 Bytes

ydbd size dashboard

github-actions · 2024-06-19T12:54:18Z

⚪ 2024-06-19 15:50:45 UTC Pre-commit check for 22be482 has started.
⚪ 2024-06-19 15:53:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-19 15:54:37 UTC Build successful.
⚪ 2024-06-19 15:54:49 UTC Tests are running...
🔴 2024-06-19 16:06:18 UTC Test run completed, no test results found for commit b57d76d. Please check test log.
⚫ 2024-06-19 16:06:57 UTC Check cancelled

github-actions · 2024-06-19T16:20:41Z

⚪ 2024-06-19 16:20:41 UTC Pre-commit check for 609a42d has started.
⚪ 2024-06-19 16:23:03 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-19 16:31:16 UTC Build successful.
⚪ 2024-06-19 16:31:26 UTC Tests are running...
🔴 2024-06-19 18:15:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10878	10818	0	17	32	11

🟢 2024-06-19 18:16:09 UTC merge: 609a42d ydbd size 5.7 GiB -6.8 KiB -0.000% vs build main: 6efb9e8

Build size details

main: 6efb9e8 ydbd build size:

binary size 6 148 811 400 Bytes
stripped binary size 1 527 388 480 Bytes

merge: 609a42d ydbd build size:

binary size 6 148 804 392 Bytes
stripped binary size 1 527 389 184 Bytes

ydbd size dashboard

github-actions · 2024-06-19T16:20:59Z

⚪ 2024-06-19 16:20:59 UTC Pre-commit check for 609a42d has started.
⚪ 2024-06-19 16:23:25 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-19 16:38:41 UTC Build successful.

github-actions · 2024-06-19T16:21:05Z

⚪ 2024-06-20 07:53:44 UTC Pre-commit check for 609a42d has started.
⚪ 2024-06-20 07:56:19 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-20 07:57:30 UTC Build successful.
⚪ 2024-06-20 07:57:47 UTC Tests are running...
🟢 2024-06-20 09:21:31 UTC Tests successful.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15134	13851	0	0	1274	9

🟢 2024-06-20 09:22:17 UTC merge: 609a42d ydbd size 8.6 GiB +8.9 KiB +0.000% vs build main: c3e7cb4

Build size details

main: c3e7cb4 ydbd build size:

binary size 9 214 102 216 Bytes
stripped binary size 711 255 920 Bytes

merge: 609a42d ydbd build size:

binary size 9 214 111 376 Bytes
stripped binary size 711 255 600 Bytes

ydbd size dashboard

…latform#5650)

molotkov-and added 3 commits June 17, 2024 14:46

Mask certificate

df8aa18

Refactoring

b59b4e1

Small fix

69a5fca

molotkov-and requested a review from adameat June 17, 2024 16:17

Print certificate suffix in debug message

146d864

molotkov-and changed the title ~~[Ticket parser] Mask certificate~~ [Ticket parser] Print certificate suffix in debug message Jun 18, 2024

Print fingerptint of certificate

b57d76d

molotkov-and changed the title ~~[Ticket parser] Print certificate suffix in debug message~~ [Ticket parser] Print certificate fingerprint in debug message Jun 19, 2024

adameat reviewed Jun 19, 2024

View reviewed changes

Use default constant for fingerprint length

a2d888c

molotkov-and requested a review from adameat June 20, 2024 10:58

adameat approved these changes Jun 20, 2024

View reviewed changes

molotkov-and merged commit 58f6122 into ydb-platform:main Jun 20, 2024
10 of 12 checks passed

molotkov-and deleted the register-node/mask-token-by-cert branch June 20, 2024 11:20

molotkov-and added a commit to molotkov-and/ydb that referenced this pull request Jun 20, 2024

[Ticket parser] Print certificate fingerprint in debug message (ydb-p…

fae14a3

…latform#5650)

GrigoriyPA mentioned this pull request Jun 20, 2024

YQ splitted fq/s3/test_s3.py tests #5798

Merged

molotkov-and added a commit to molotkov-and/ydb that referenced this pull request Jun 24, 2024

[Ticket parser] Print certificate fingerprint in debug message (ydb-p…

5caf35f

…latform#5650)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ticket parser] Print certificate fingerprint in debug message #5650

[Ticket parser] Print certificate fingerprint in debug message #5650

molotkov-and commented Jun 17, 2024

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

adameat Jun 19, 2024

molotkov-and Jun 19, 2024

github-actions bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

[Ticket parser] Print certificate fingerprint in debug message #5650

[Ticket parser] Print certificate fingerprint in debug message #5650

Conversation

molotkov-and commented Jun 17, 2024

github-actions bot commented Jun 17, 2024 • edited Loading

github-actions bot commented Jun 17, 2024 • edited Loading

github-actions bot commented Jun 17, 2024 • edited Loading

github-actions bot commented Jun 18, 2024 • edited Loading

github-actions bot commented Jun 18, 2024 • edited Loading

github-actions bot commented Jun 18, 2024 • edited Loading

github-actions bot commented Jun 19, 2024 • edited Loading

adameat Jun 19, 2024

Choose a reason for hiding this comment

molotkov-and Jun 19, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 19, 2024 • edited Loading

github-actions bot commented Jun 19, 2024 • edited Loading

github-actions bot commented Jun 19, 2024 • edited Loading

github-actions bot commented Jun 19, 2024 • edited Loading

github-actions bot commented Jun 19, 2024 • edited Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading