Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ApplyReplicationChanges #5683

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Fix ApplyReplicationChanges #5683

merged 1 commit into from
Jun 18, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Jun 18, 2024 •
edited
Loading

Changelog entry

Check shard state before any other checks in ApplyReplicationChanges handler.

Changelog category

  • Bugfix

Additional information

...

@CyberROFL CyberROFL self-assigned this Jun 18, 2024
@CyberROFL CyberROFL requested a review from snaury June 18, 2024 15:28
@CyberROFL CyberROFL marked this pull request as ready for review June 18, 2024 15:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

⚪ 2024-06-18 15:32:59 UTC Pre-commit check for 27d5427 has started.
⚪ 2024-06-18 15:35:21 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-18 15:37:06 UTC Build successful.
⚪ 2024-06-18 15:37:14 UTC Tests are running...
🔴 2024-06-18 17:20:53 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9620 9575 0 16 21 8

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

⚪ 2024-06-18 15:36:14 UTC Pre-commit check for 27d5427 has started.
⚪ 2024-06-18 15:38:50 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-18 15:41:37 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

⚪ 2024-06-18 15:42:39 UTC Pre-commit check for 27d5427 has started.
⚪ 2024-06-18 15:45:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-18 15:47:51 UTC Build successful.
⚪ 2024-06-18 15:48:06 UTC Tests are running...
🔴 2024-06-18 17:10:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13866 12573 0 2 1277 14

@CyberROFL CyberROFL enabled auto-merge (squash) June 18, 2024 16:06
@CyberROFL CyberROFL merged commit 40bcf99 into ydb-platform:main Jun 18, 2024
11 of 15 checks passed
@CyberROFL CyberROFL deleted the fix-repl-apply branch June 18, 2024 17:33
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jun 18, 2024
@CyberROFL
Fix ApplyReplicationChanges (ydb-platform#5683)
71a783d
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 19, 2024
Merged
This was referenced Jun 19, 2024
Closed
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 20, 2024
Merged
This was referenced Jun 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snaury snaury snaury approved these changes

@Enjection Enjection Enjection approved these changes

Assignees

@CyberROFL CyberROFL

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CyberROFL @snaury @Enjection