Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pushdown logical ops with scalar argument. #6142

Merged

Conversation

Tony-Romanov
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Jul 1, 2024

2024-07-01 15:44:34 UTC Pre-commit check for 179273d has started.
2024-07-01 15:46:59 UTC Build linux-x86_64-release-clang14 is running...

Copy link

github-actions bot commented Jul 1, 2024

2024-07-01 16:07:25 UTC Pre-commit check for 179273d has started.
2024-07-01 16:09:51 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-01 16:48:12 UTC Build successful.
2024-07-01 16:48:27 UTC Tests are running...
🔴 2024-07-01 18:15:32 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13821 12505 0 1 1304 11

🔴 2024-07-01 18:16:07 UTC ydbd size 8.3 GiB changed* by +2.6 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 90c247b merge: 179273d diff diff %
ydbd size 8 954 166 152 Bytes 8 956 852 728 Bytes +2.6 MiB +0.030%
ydbd stripped size 488 284 744 Bytes 488 394 344 Bytes +107.0 KiB +0.022%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Tony-Romanov Tony-Romanov removed the request for review from ivanmorozov333 July 1, 2024 16:33
Copy link

github-actions bot commented Jul 1, 2024

2024-07-01 16:35:02 UTC Pre-commit check for 179273d has started.
2024-07-01 16:37:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-01 17:00:58 UTC Build successful.
2024-07-01 17:01:10 UTC Tests are running...
🔴 2024-07-01 19:02:57 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9709 9127 0 91 321 170

🔴 2024-07-01 19:03:39 UTC ydbd size 5.4 GiB changed* by +3.1 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: dad8344 merge: 179273d diff diff %
ydbd size 5 831 125 664 Bytes 5 834 337 480 Bytes +3.1 MiB +0.055%
ydbd stripped size 1 251 057 864 Bytes 1 251 565 992 Bytes +496.2 KiB +0.041%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Tony-Romanov Tony-Romanov marked this pull request as ready for review July 1, 2024 18:55
@Tony-Romanov Tony-Romanov enabled auto-merge (squash) July 1, 2024 19:05
Copy link

github-actions bot commented Jul 2, 2024

2024-07-02 08:35:50 UTC Pre-commit check for b2bcc6d has started.
2024-07-02 08:38:14 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-02 08:43:57 UTC Build successful.

Copy link

github-actions bot commented Jul 2, 2024

2024-07-02 08:37:46 UTC Pre-commit check for b2bcc6d has started.
2024-07-02 08:40:12 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-02 09:18:41 UTC Build successful.
2024-07-02 09:18:57 UTC Tests are running...
🔴 2024-07-02 10:46:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13824 12500 0 3 1307 14

🟡 2024-07-02 10:46:51 UTC ydbd size 8.3 GiB changed* by +717.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c7a7fef merge: b2bcc6d diff diff %
ydbd size 8 948 843 912 Bytes 8 949 578 360 Bytes +717.2 KiB +0.008%
ydbd stripped size 487 865 064 Bytes 487 871 912 Bytes +6.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 2, 2024

2024-07-02 09:03:23 UTC Pre-commit check for b2bcc6d has started.
2024-07-02 09:05:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-02 09:29:46 UTC Build successful.
2024-07-02 09:29:58 UTC Tests are running...
🔴 2024-07-02 11:29:35 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9723 9117 0 100 331 175

🟢 2024-07-02 11:30:25 UTC ydbd size 5.4 GiB changed* by +752 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6e81fbe merge: b2bcc6d diff diff %
ydbd size 5 829 995 584 Bytes 5 829 996 336 Bytes +752 Bytes +0.000%
ydbd stripped size 1 251 554 056 Bytes 1 251 554 248 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Tony-Romanov Tony-Romanov merged commit 13b6703 into ydb-platform:main Jul 2, 2024
8 of 12 checks passed
@Tony-Romanov Tony-Romanov deleted the fix_pushdown_logical_ops branch July 2, 2024 11:53
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jul 2, 2024
shmel1k pushed a commit to shmel1k/ydb that referenced this pull request Jul 2, 2024
shmel1k added a commit that referenced this pull request Jul 2, 2024
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Jul 5, 2024
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants