Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set predicate-extract config default #6456

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

ssmike
Copy link
Collaborator

@ssmike ssmike commented Jul 9, 2024

Changelog category

  • Not for changelog (changelog entry is not required)

@ssmike ssmike requested a review from a team as a code owner July 9, 2024 09:03
Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 09:12:00 UTC Pre-commit check for 50d6795 has started.
2024-07-09 09:15:16 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-09 09:47:46 UTC Build successful.

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 09:33:36 UTC Pre-commit check for 50d6795 has started.
2024-07-09 09:36:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-09 10:18:36 UTC Build successful.
2024-07-09 10:18:47 UTC Tests are running...
🔴 2024-07-09 12:21:38 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11225 10632 0 95 323 175

🟢 2024-07-09 12:22:29 UTC ydbd size 5.2 GiB changed* by -240 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 44a1cd0 merge: 50d6795 diff diff %
ydbd size 5 615 664 240 Bytes 5 615 664 000 Bytes -240 Bytes -0.000%
ydbd stripped size 1 211 071 912 Bytes 1 211 071 848 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 09:39:14 UTC Pre-commit check for 50d6795 has started.
2024-07-09 09:42:05 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-09 10:42:09 UTC Build successful.
2024-07-09 10:42:21 UTC Tests are running...
🔴 2024-07-09 12:39:26 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39745 34492 0 13 5220 20

🟢 2024-07-09 12:40:10 UTC ydbd size 8.1 GiB changed* by -128 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 44a1cd0 merge: 50d6795 diff diff %
ydbd size 8 725 589 248 Bytes 8 725 589 120 Bytes -128 Bytes -0.000%
ydbd stripped size 477 140 648 Bytes 477 140 648 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 08:04:07 UTC Pre-commit check for fb6bd90 has started.
2024-07-10 08:06:51 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 08:43:35 UTC Build successful.
2024-07-10 08:43:48 UTC Tests are running...
🔴 2024-07-10 10:41:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11229 10652 0 89 315 173

🟢 2024-07-10 10:41:59 UTC ydbd size 5.2 GiB changed* by -240 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: d0cc485 merge: fb6bd90 diff diff %
ydbd size 5 616 259 544 Bytes 5 616 259 304 Bytes -240 Bytes -0.000%
ydbd stripped size 1 211 194 632 Bytes 1 211 194 568 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 08:04:54 UTC Pre-commit check for fb6bd90 has started.
2024-07-10 08:07:54 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 09:03:23 UTC Build successful.
2024-07-10 09:03:33 UTC Tests are running...
🔴 2024-07-10 10:42:39 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39753 34511 0 3 5219 20

🟢 2024-07-10 10:43:16 UTC ydbd size 8.1 GiB changed* by -128 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: d0cc485 merge: fb6bd90 diff diff %
ydbd size 8 726 646 976 Bytes 8 726 646 848 Bytes -128 Bytes -0.000%
ydbd stripped size 477 172 520 Bytes 477 172 520 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 10, 2024

2024-07-10 08:05:58 UTC Pre-commit check for fb6bd90 has started.
2024-07-10 08:09:09 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 08:40:14 UTC Build successful.

@gridnevvvit gridnevvvit self-requested a review July 10, 2024 10:52
@ssmike ssmike enabled auto-merge (squash) July 10, 2024 10:52
@gridnevvvit
Copy link
Member

the feature was enabled successfully in major installation so I think that is ok to make it enabled by default in 24-3

@ssmike ssmike merged commit 0e4b669 into ydb-platform:stable-24-3 Jul 10, 2024
8 of 12 checks passed
@ssmike ssmike deleted the set-defaults-24-3 branch August 3, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants