Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-3: Fix bugs in: change exchange split, removing schema snapshots & emitting of resolved timestamps #6616

Merged
merged 6 commits into from
Jul 14, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Jul 12, 2024

Changelog entry

  • Fill change exchange split & activation lists just before commit.
  • Add records to change queue at Execute() stage.
  • Fix bug with broadcasting records.
  • Continue to emit resolved timestamp after table merge.

Changelog category

  • Bugfix

Additional information

  • Fix alter replication config.

@CyberROFL CyberROFL self-assigned this Jul 12, 2024
Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 11:13:04 UTC Pre-commit check for 1a56b2d has started.
2024-07-12 11:16:13 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-12 11:23:43 UTC Build failed. see the build logs.
🔴 2024-07-12 11:23:45 UTC Tests run skipped.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 11:13:31 UTC Pre-commit check for 1a56b2d has started.
2024-07-12 11:16:41 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-12 11:23:10 UTC Build failed. see the build logs.
🔴 2024-07-12 11:23:11 UTC Tests run skipped.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 11:13:56 UTC Pre-commit check for 1a56b2d has started.
2024-07-12 11:17:08 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-12 11:28:31 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 12:04:40 UTC Pre-commit check for 16d8816 has started.
2024-07-12 12:07:23 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-12 12:19:17 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 12:07:17 UTC Pre-commit check for 16d8816 has started.
2024-07-12 12:09:57 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-12 12:18:06 UTC Build failed. see the build logs.
🔴 2024-07-12 12:18:07 UTC Tests run skipped.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 12:27:34 UTC Pre-commit check for 16d8816 has started.
2024-07-12 12:30:18 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-12 12:38:06 UTC Build failed. see the build logs.
🔴 2024-07-12 12:38:07 UTC Tests run skipped.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 13:47:18 UTC Pre-commit check for ebbd0c1 has started.
2024-07-12 13:50:07 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-12 14:00:08 UTC Build successful.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 13:49:06 UTC Pre-commit check for ebbd0c1 has started.
2024-07-12 13:52:21 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-12 14:17:50 UTC Build successful.
2024-07-12 14:18:01 UTC Tests are running...
🔴 2024-07-12 16:24:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11213 10630 0 92 316 175

🟡 2024-07-12 16:24:57 UTC ydbd size 5.2 GiB changed* by +311.2 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 0e4b669 merge: ebbd0c1 diff diff %
ydbd size 5 616 270 384 Bytes 5 616 589 056 Bytes +311.2 KiB +0.006%
ydbd stripped size 1 211 197 832 Bytes 1 211 251 624 Bytes +52.5 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 13:52:40 UTC Pre-commit check for ebbd0c1 has started.
2024-07-12 13:55:18 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-12 14:36:43 UTC Build successful.
2024-07-12 14:37:07 UTC Tests are running...
🔴 2024-07-12 16:24:01 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39735 34492 0 3 5220 20

🟡 2024-07-12 16:24:34 UTC ydbd size 8.1 GiB changed* by +663.9 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 0e4b669 merge: ebbd0c1 diff diff %
ydbd size 8 726 657 816 Bytes 8 727 337 656 Bytes +663.9 KiB +0.008%
ydbd stripped size 477 173 864 Bytes 477 191 656 Bytes +17.4 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL marked this pull request as ready for review July 12, 2024 16:11
@CyberROFL CyberROFL requested a review from a team as a code owner July 12, 2024 16:11
@CyberROFL CyberROFL enabled auto-merge (squash) July 12, 2024 16:11
@CyberROFL CyberROFL merged commit 35253da into ydb-platform:stable-24-3 Jul 14, 2024
8 of 12 checks passed
@CyberROFL CyberROFL deleted the cdc-fixes-24-3 branch July 24, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants